From: Ralf Baechle <ralf@linux-mips.org>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH v3] mips/alchemy: add basic support for the GPR board
Date: Fri, 23 Jul 2010 19:44:48 +0100 [thread overview]
Message-ID: <20100723184448.GB17634@linux-mips.org> (raw)
In-Reply-To: <1279185683-21037-1-git-send-email-wg@grandegger.com>
On Thu, Jul 15, 2010 at 11:21:23AM +0200, Wolfgang Grandegger wrote:
> From: Wolfgang Grandegger <wg@denx.de>
>
> This patch adds basic support for the General Purpose Router (GPR)
> board from Trapeze ITS.
>
> Signed-off-by: Wolfgang Grandegger <wg@denx.de>
> ---
>
> Something went wrong with my previous "git send-email", please ignore.
It even triggers a bug in Patchwork - it doens't handle subject-less
patches very gracefully.
+static void gpr_power_off(void)
+{
+ printk(KERN_ALERT "It's now safe to remove power\n");
My favorite line to delete from kernel patches. Messages to the user
belong into userspace.
+ while (1)
+ asm volatile (".set mips3 ; wait ; .set mips0");
+}
+
+static void gpr_power_off(void)
+{
[..]
+ while (1)
+ asm volatile (".set mips3 ; wait ; .set mips0");
+}
Call cpu_wait() instead of open coding the WAIT instruction. This avoids
certain restrictions of the WAIT instruction.
I've sorted that and also updated the defconfig file. As is due to
other changes make gpr_defconfig did configure a kernel for IP22. The
changed kconfig behaviour is worse than useless!
Queued for 2.6.36,
Ralf
next prev parent reply other threads:[~2010-07-23 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 9:21 [PATCH v3] mips/alchemy: add basic support for the GPR board Wolfgang Grandegger
2010-07-23 18:44 ` Ralf Baechle [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-07-14 13:42 Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100723184448.GB17634@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.