From: Jonathan Nieder <jrnieder@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: [PATCH 6/9] setup: split off a function to handle hitting ceiling in repo search
Date: Sat, 24 Jul 2010 06:26:41 -0500 [thread overview]
Message-ID: <20100724112640.GF16054@burratino> (raw)
In-Reply-To: <20100724111505.GC7150@burratino>
Perhaps some day, other similar conditions (hitting the mount point,
hitting the root of the file system) will share this code.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
setup.c | 21 ++++++++++++---------
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/setup.c b/setup.c
index ec11c46..9fc05e2 100644
--- a/setup.c
+++ b/setup.c
@@ -378,6 +378,16 @@ static const char *setup_bare_git_dir(const char *work_tree_env,
return NULL;
}
+static const char *setup_nongit(const char *cwd, int *nongit_ok)
+{
+ if (!nongit_ok)
+ die("Not a git repository (or any of the parent directories): %s", DEFAULT_GIT_DIR_ENVIRONMENT);
+ if (chdir(cwd))
+ die_errno("Cannot come back to cwd");
+ *nongit_ok = 1;
+ return NULL;
+}
+
/*
* We cannot decide in this function whether we are in the work tree or
* not, since the config can only be read _after_ this function was called.
@@ -443,15 +453,8 @@ const char *setup_git_directory_gently(int *nongit_ok)
return setup_bare_git_dir(work_tree_env, offset,
len, cwd, nongit_ok);
while (--offset > ceil_offset && cwd[offset] != '/');
- if (offset <= ceil_offset) {
- if (nongit_ok) {
- if (chdir(cwd))
- die_errno("Cannot come back to cwd");
- *nongit_ok = 1;
- return NULL;
- }
- die("Not a git repository (or any of the parent directories): %s", DEFAULT_GIT_DIR_ENVIRONMENT);
- }
+ if (offset <= ceil_offset)
+ return setup_nongit(cwd, nongit_ok);
if (one_filesystem) {
if (stat("..", &buf)) {
cwd[offset] = '\0';
--
1.7.2.rc3.593.g19611.dirty
next prev parent reply other threads:[~2010-07-24 11:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 12:04 [PATCH 1/2] worktree setup: return to original cwd if prefix is set NULL Nguyễn Thái Ngọc Duy
2010-07-23 12:04 ` [PATCH 2/2] Revert "rehabilitate 'git index-pack' inside the object store" Nguyễn Thái Ngọc Duy
2010-07-23 14:38 ` [PATCH 1/2] worktree setup: return to original cwd if prefix is set NULL Ævar Arnfjörð Bjarmason
2010-07-24 0:50 ` Nguyen Thai Ngoc Duy
2010-07-24 1:16 ` Ævar Arnfjörð Bjarmason
2010-07-23 19:47 ` Nguyễn Thái Ngọc Duy
2010-07-24 11:15 ` [PATCH 0/9] setup_git_directory(): return to original cwd upon reaching .git Jonathan Nieder
2010-07-24 11:16 ` [PATCH 1/9] t1501 (rev-parse): clarify Jonathan Nieder
2010-07-24 11:18 ` [PATCH 2/9] tests: try git apply from subdir of toplevel Jonathan Nieder
2010-07-24 11:19 ` [PATCH 3/9] setup: split off $GIT_DIR-set case from setup_git_directory_gently Jonathan Nieder
2010-07-24 12:15 ` Nguyen Thai Ngoc Duy
2010-07-24 11:20 ` [PATCH 4/9] setup: split off a function to checks working dir for .git file Jonathan Nieder
2010-07-24 11:56 ` Nguyen Thai Ngoc Duy
2010-07-24 12:11 ` Jonathan Nieder
2010-07-24 11:25 ` [PATCH 5/9] setup: split off code to handle stumbling upon a repository Jonathan Nieder
2010-07-24 11:26 ` Jonathan Nieder [this message]
2010-07-24 11:27 ` [PATCH 7/9] setup: split off get_device_or_die helper Jonathan Nieder
2010-07-24 11:29 ` [PATCH 8/9] setup: do not forget working dir from subdir of gitdir Jonathan Nieder
2010-07-24 11:30 ` [PATCH 9/9] Revert "rehabilitate 'git index-pack' inside the object store" Jonathan Nieder
2010-07-24 11:45 ` [PATCH 0/9] setup_git_directory(): return to original cwd upon reaching .git Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100724112640.GF16054@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.