From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Chinner <david@fromorbit.com>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Subject: Re: linux-next: OOPS at boot time
Date: Sat, 24 Jul 2010 13:27:50 +0100 [thread overview]
Message-ID: <20100724122750.GA10675@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100723100408.GB3305@quack.suse.cz>
On Fri, Jul 23, 2010 at 12:04:08PM +0200, Jan Kara wrote:
> > @@ -1428,8 +1429,10 @@ out:
> > /*
> > * Undo the block allocation
> > */
> > - if (!performed_allocation)
> > - dquot_free_block(inode, *count);
> > + if (!performed_allocation) {
> > + dquot_free_block_nodirty(inode, *count);
> > + mark_inode_dirty(inode);
> > + }
> > brelse(bitmap_bh);
> > return 0;
> > }
> Sorry, but the above two changes look stupid... Why call _nodirty variant
> and dirty the inode immediately after that? It happens in two other places
> in your patch as well...
Frankly, I don't believe that dquot_free_block() is _ever_ the right interface;
please, leave dirtying the inode to the filesystem and let it be explicit.
next prev parent reply other threads:[~2010-07-24 12:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 6:41 linux-next: OOPS at boot time Stephen Rothwell
2010-07-20 9:12 ` Milton Miller
2010-07-20 10:36 ` Andrew Morton
2010-07-20 22:45 ` Dave Chinner
2010-07-21 0:44 ` Andrew Morton
2010-07-21 5:20 ` Dave Chinner
2010-07-21 7:29 ` Andrew Morton
2010-07-21 7:48 ` Stephen Rothwell
2010-07-21 12:11 ` Jan Kara
2010-07-21 17:49 ` Al Viro
2010-07-21 21:40 ` Al Viro
2010-07-23 10:04 ` Jan Kara
2010-07-24 12:27 ` Al Viro [this message]
2010-07-21 23:19 ` Dave Chinner
2010-07-21 12:19 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100724122750.GA10675@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.