All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/6] Makefile: Include subdirectories in "make cover" reports
Date: Sun, 25 Jul 2010 00:37:56 +0200	[thread overview]
Message-ID: <201007250037.57086.trast@student.ethz.ch> (raw)
In-Reply-To: <1280004663-4887-3-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:
> The buildin/, xdiff/ and compat/ subdirectories weren't being included
> in the gcov aggregation, nor were the files there being cleaned up.
[...]
>  coverage-clean:
> -	rm -f *.gcda *.gcno
> +	$(RM) *.gcov *.gcda *.gcno
> +	$(RM) builtin/*.gcov
> +	$(RM) builtin/*.gcda
> +	$(RM) builtin/*.gcno

By the same logic, the xdiff and compat directories should also be
included here.  Maybe also block-sha1?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2010-07-24 22:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-24 20:50 [PATCH 0/6] Detailed test coverage reports for Git Ævar Arnfjörð Bjarmason
2010-07-24 20:50 ` [PATCH 1/6] gitignore: Ignore files generated by "make coverage" Ævar Arnfjörð Bjarmason
2010-07-24 20:50 ` [PATCH 2/6] Makefile: Include subdirectories in "make cover" reports Ævar Arnfjörð Bjarmason
2010-07-24 22:37   ` Thomas Rast [this message]
2010-07-24 23:28     ` Ævar Arnfjörð Bjarmason
2010-07-24 23:41       ` Jonathan Nieder
2010-07-26  5:44         ` Junio C Hamano
2010-07-24 20:51 ` [PATCH 3/6] Makefile: Split out the untested functions target Ævar Arnfjörð Bjarmason
2010-07-24 23:02   ` Thomas Rast
2010-07-24 23:29     ` Ævar Arnfjörð Bjarmason
2010-07-24 20:51 ` [PATCH 4/6] Makefile: Add coverage-report-cover-db target Ævar Arnfjörð Bjarmason
2010-07-24 23:01   ` Thomas Rast
2010-07-24 23:28     ` Ævar Arnfjörð Bjarmason
2010-07-24 20:51 ` [PATCH 5/6] Makefile: Add coverage-report-cover-db-html target Ævar Arnfjörð Bjarmason
2010-07-24 20:51 ` [PATCH 6/6] t/README: A new section about test coverage Ævar Arnfjörð Bjarmason
2010-07-24 21:25   ` Jonathan Nieder
2010-07-24 21:29     ` Jonathan Nieder
2010-07-24 23:17     ` Ævar Arnfjörð Bjarmason
2010-07-24 23:32       ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201007250037.57086.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.