From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sunset.davemloft.net (74-93-104-97-Washington.hfc.comcastbusiness.net [74.93.104.97]) by ozlabs.org (Postfix) with ESMTP id C9696B70E8 for ; Tue, 27 Jul 2010 08:48:38 +1000 (EST) Date: Mon, 26 Jul 2010 15:48:54 -0700 (PDT) Message-Id: <20100726.154854.35052662.davem@davemloft.net> To: grant.likely@secretlab.ca Subject: Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() From: David Miller In-Reply-To: References: <20100726220405.1550.63442.stgit@angua> <20100726222627.GA23501@merkur.ravnborg.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Cc: sfr@canb.auug.org.au, monstr@monstr.eu, microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org, sam@ravnborg.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Grant Likely Date: Mon, 26 Jul 2010 16:42:20 -0600 > It protects against some later include file doing a #define > of_node_to_nid and thus resulting in an inconsistent definition. If > some code tries to do this then the preprocessor will complain. This > is the pattern that Stephen suggested. Also, it would be nice to unravel the "0" vs. "-1" default inconsistency. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Mon, 26 Jul 2010 22:48:54 +0000 Subject: Re: [PATCH v3] of: Create asm-generic/of.h and provide default Message-Id: <20100726.154854.35052662.davem@davemloft.net> List-Id: References: <20100726220405.1550.63442.stgit@angua> <20100726222627.GA23501@merkur.ravnborg.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org Cc: sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org, microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org From: Grant Likely Date: Mon, 26 Jul 2010 16:42:20 -0600 > It protects against some later include file doing a #define > of_node_to_nid and thus resulting in an inconsistent definition. If > some code tries to do this then the preprocessor will complain. This > is the pattern that Stephen suggested. Also, it would be nice to unravel the "0" vs. "-1" default inconsistency. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755722Ab0GZWsk (ORCPT ); Mon, 26 Jul 2010 18:48:40 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:58146 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755684Ab0GZWsh (ORCPT ); Mon, 26 Jul 2010 18:48:37 -0400 Date: Mon, 26 Jul 2010 15:48:54 -0700 (PDT) Message-Id: <20100726.154854.35052662.davem@davemloft.net> To: grant.likely@secretlab.ca Cc: sam@ravnborg.org, sfr@canb.auug.org.au, monstr@monstr.eu, microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, benh@kernel.crashing.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() From: David Miller In-Reply-To: References: <20100726220405.1550.63442.stgit@angua> <20100726222627.GA23501@merkur.ravnborg.org> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grant Likely Date: Mon, 26 Jul 2010 16:42:20 -0600 > It protects against some later include file doing a #define > of_node_to_nid and thus resulting in an inconsistent definition. If > some code tries to do this then the preprocessor will complain. This > is the pattern that Stephen suggested. Also, it would be nice to unravel the "0" vs. "-1" default inconsistency. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3] of: Create asm-generic/of.h and provide default of_node_to_nid() Date: Mon, 26 Jul 2010 15:48:54 -0700 (PDT) Message-ID: <20100726.154854.35052662.davem@davemloft.net> References: <20100726220405.1550.63442.stgit@angua> <20100726222627.GA23501@merkur.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org Cc: sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org, microblaze-uclinux-rVRm/Wmeqae7NGdpmJTKYQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org List-Id: devicetree@vger.kernel.org From: Grant Likely Date: Mon, 26 Jul 2010 16:42:20 -0600 > It protects against some later include file doing a #define > of_node_to_nid and thus resulting in an inconsistent definition. If > some code tries to do this then the preprocessor will complain. This > is the pattern that Stephen suggested. Also, it would be nice to unravel the "0" vs. "-1" default inconsistency.