From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754444Ab0GZLET (ORCPT ); Mon, 26 Jul 2010 07:04:19 -0400 Received: from gir.skynet.ie ([193.1.99.77]:42582 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275Ab0GZLER (ORCPT ); Mon, 26 Jul 2010 07:04:17 -0400 Date: Mon, 26 Jul 2010 12:04:01 +0100 From: Mel Gorman To: Wu Fengguang Cc: Andrew Morton , Dave Chinner , Christoph Hellwig , Chris Mason , Jens Axboe , LKML , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 6/6] writeback: introduce writeback_control.inodes_written Message-ID: <20100726110401.GO5300@csn.ul.ie> References: <20100722050928.653312535@intel.com> <20100722061823.196659592@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20100722061823.196659592@intel.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2010 at 01:09:34PM +0800, Wu Fengguang wrote: > Introduce writeback_control.inodes_written to count successful > ->write_inode() calls. A non-zero value means there are some > progress on writeback, in which case more writeback will be tried. > > This prevents aborting a background writeback work prematually when > the current set of inodes for IO happen to be metadata-only dirty. > > Signed-off-by: Wu Fengguang Seems reasonable. Acked-by: Mel Gorman -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mel Gorman Subject: Re: [PATCH 6/6] writeback: introduce writeback_control.inodes_written Date: Mon, 26 Jul 2010 12:04:01 +0100 Message-ID: <20100726110401.GO5300@csn.ul.ie> References: <20100722050928.653312535@intel.com> <20100722061823.196659592@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Cc: Andrew Morton , Dave Chinner , Christoph Hellwig , Chris Mason , Jens Axboe , LKML , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org To: Wu Fengguang Return-path: Content-Disposition: inline In-Reply-To: <20100722061823.196659592@intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Jul 22, 2010 at 01:09:34PM +0800, Wu Fengguang wrote: > Introduce writeback_control.inodes_written to count successful > ->write_inode() calls. A non-zero value means there are some > progress on writeback, in which case more writeback will be tried. > > This prevents aborting a background writeback work prematually when > the current set of inodes for IO happen to be metadata-only dirty. > > Signed-off-by: Wu Fengguang Seems reasonable. Acked-by: Mel Gorman -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org