From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: Huacai Chen <zltjiangshi@gmail.com>,
qemu-devel@nongnu.org, Takashi YOSHII <takasi-y@ops.dti.ne.jp>,
Blue Swirl <blauwirbel@gmail.com>,
Paul Brook <paul@codesourcery.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] Re: [PATCH 2/3] pci/pci_host: pci host bus initialization clean up.
Date: Mon, 26 Jul 2010 14:33:30 +0300 [thread overview]
Message-ID: <20100726113330.GC22683@redhat.com> (raw)
In-Reply-To: <4ee70a31481376d2a3e02df95d69e3d79c8db19f.1280141797.git.yamahata@valinux.co.jp>
> +/*
> + * TODO: there remains some boards which doesn't use PCIHostState.
> + * Enhance PCIHostState API and convert remaining boards.
I think I remember this comment from Paul:
On Tuesday 12 January 2010, Isaku Yamahata wrote:
> To use pci host framework, use PCIHostState instead of PCIBus in
> PCIVPBState.
No.
pci_host.[ch] provides very specific functionality, it is not a generic
PCI host device. Specifically it provides indirect access to PCI config
space via a memory mapped {address,data} pair. The versatile PCI host exposes PCI
config space directly, so should not be using this code.
If you want a generic framework for PCI hosts then you need to use
something else. If nothing else, assuming that a PCI host bridge is always is
SysBus device is wrong.
Still applies?
--
MST
next prev parent reply other threads:[~2010-07-26 11:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 10:59 [Qemu-devel] [PATCH 0/3] pci, pcihost: pci host bus clean up Isaku Yamahata
2010-07-26 10:59 ` [Qemu-devel] [PATCH 1/3] pci_host: remove PCIHostState::busdev Isaku Yamahata
2010-07-26 10:59 ` [Qemu-devel] [PATCH 2/3] pci/pci_host: pci host bus initialization clean up Isaku Yamahata
2010-07-26 11:33 ` Michael S. Tsirkin [this message]
2010-08-05 1:51 ` [Qemu-devel] " Isaku Yamahata
2010-07-26 10:59 ` [Qemu-devel] [PATCH 3/3] mips64el: fulong: fix pci multifunction bit Isaku Yamahata
[not found] ` <AANLkTi=328Fgcb4+aKQjF5k-ckzPuD=jSXasttcO2jya@mail.gmail.com>
[not found] ` <20100727021822.GA5488@valinux.co.jp>
2010-07-27 3:10 ` [Qemu-devel] " chen huacai
2010-07-27 3:54 ` [Qemu-devel] [PATCH 0/3] pci, pcihost: pci host bus clean up Aurelien Jarno
2010-07-27 4:06 ` Isaku Yamahata
2010-07-27 6:23 ` [Qemu-devel] [PATCH for master " Isaku Yamahata
2010-07-27 6:23 ` [Qemu-devel] [PATCH for master 1/3] pci: move out pci internal structures, PCIBus, PCIBridge, and pci_bus_info Isaku Yamahata
2010-07-27 6:23 ` [Qemu-devel] [PATCH for master 2/3] pci_host: remove PCIHostState::busdev Isaku Yamahata
2010-07-27 6:23 ` [Qemu-devel] [PATCH for master 3/3] pci/pci_host: pci host bus initialization clean up Isaku Yamahata
2010-07-30 22:01 ` [Qemu-devel] [PATCH for master 0/3] pci, pcihost: pci host bus " Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100726113330.GC22683@redhat.com \
--to=mst@redhat.com \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=takasi-y@ops.dti.ne.jp \
--cc=yamahata@valinux.co.jp \
--cc=zltjiangshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.