From: Matthew Garrett <mjg59@srcf.ucam.org>
To: yakui.zhao@intel.com
Cc: lenb@kernel.org, minyard@acm.org, linux-acpi@vger.kernel.org,
openipmi-developer@lists.sourceforge.net,
Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [PATCH_v8 1/2] IPMI/ACPI: Define acpi_ipmi notifier hook functions
Date: Mon, 26 Jul 2010 16:11:48 +0100 [thread overview]
Message-ID: <20100726151148.GA31084@srcf.ucam.org> (raw)
In-Reply-To: <1280155565-2938-2-git-send-email-yakui.zhao@intel.com>
On Mon, Jul 26, 2010 at 10:46:04PM +0800, yakui.zhao@intel.com wrote:
> @@ -2133,6 +2142,11 @@ static int __devinit ipmi_pnp_probe(struct pnp_dev *dev,
> if (!info)
> return -ENOMEM;
>
> + pnp_ipmi = kzalloc(sizeof(*pnp_ipmi), GFP_KERNEL);
> + if (!pnp_ipmi) {
> + kfree(info);
> + return -ENOMEM;
> + }
This will never get called if the hardware has a PCI IPMI interface.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-07-26 15:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 14:46 [PATCH -v8 0/2] IPMI/ACPI: Install the ACPI IPMI opregion yakui.zhao
2010-07-26 14:46 ` [PATCH_v8 1/2] IPMI/ACPI: Define acpi_ipmi notifier hook functions yakui.zhao
2010-07-26 14:46 ` [PATCH_v8 2/2] ACPI: Add the IPMI opregion driver to enable ACPI to access BMC controller yakui.zhao
2010-07-26 16:54 ` Bjorn Helgaas
2010-07-27 0:53 ` ykzhao
2010-07-26 15:11 ` Matthew Garrett [this message]
2010-07-26 15:15 ` [PATCH_v8 1/2] IPMI/ACPI: Define acpi_ipmi notifier hook functions Matthew Garrett
2010-07-26 16:52 ` Bjorn Helgaas
2010-07-27 0:35 ` ykzhao
2010-07-27 1:19 ` Corey Minyard
2010-07-27 13:22 ` Matthew Garrett
2010-07-27 14:04 ` Corey Minyard
2010-07-28 1:09 ` ykzhao
2010-07-28 3:30 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100726151148.GA31084@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=bjorn.helgaas@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.