From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>,
"ath5k-devel@lists.ath5k.org" <ath5k-devel@lists.ath5k.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
David Quan <David.Quan@atheros.com>,
"Luis R. Rodriguez" <mcgrof@bombadil.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"kernel-team@lists.ubuntu.com" <kernel-team@lists.ubuntu.com>,
Luis Rodriguez <Luis.Rodriguez@atheros.com>,
Jussi Kivilinna <jussi.kivilinna@mbnet.fi>,
"tim.gardner@canonical.com" <tim.gardner@canonical.com>
Subject: Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM
Date: Mon, 26 Jul 2010 23:29:09 +0100 [thread overview]
Message-ID: <20100726222909.GA6773@srcf.ucam.org> (raw)
In-Reply-To: <AANLkTinq-SxMHTrJM23WaeRMkU-2cySiVrkwCjDRS_o+@mail.gmail.com>
On Mon, Jul 26, 2010 at 03:26:37PM -0700, Luis R. Rodriguez wrote:
> What I meant was that the PCI config space would already have L1
> enabled if L1 worked, so I don't see why we would need to nitpick out
> specifics here. All Atheros PCIE chips should work with L1. The advise
> given is to disable L0s though. I believe AR2425 would be one which
> likely had L0s enabled but requires it to be disabled. Not sure of
> others. But this is why I am saying this can be done globally for all
> ath5k chipsets.
If L1 is set but the chip is pre-PCIe 1.1 then we'll disable L1 unless
the driver tells us that it's functional. The .inf from the Windows
driver seemed to suggest that only a subset of the chips re-enabled L1
there, but if it's ok in general then that's a straightforward one-line
patch.
--
Matthew Garrett | mjg59@srcf.ucam.org
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>,
"ath5k-devel@lists.ath5k.org" <ath5k-devel@venema.h4ckr.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
David Quan <David.Quan@atheros.com>,
"Luis R. Rodriguez" <mcgrof@bombadil.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"kernel-team@lists.ubuntu.com" <kernel-team@lists.ubuntu.com>,
Luis Rodriguez <Luis.Rodriguez@atheros.com>,
Jussi Kivilinna <jussi.kivilinna@mbnet.fi>,
"tim.gardner@canonical.com" <tim.gardner@canonical.com>
Subject: Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM
Date: Mon, 26 Jul 2010 23:29:09 +0100 [thread overview]
Message-ID: <20100726222909.GA6773@srcf.ucam.org> (raw)
In-Reply-To: <AANLkTinq-SxMHTrJM23WaeRMkU-2cySiVrkwCjDRS_o+@mail.gmail.com>
On Mon, Jul 26, 2010 at 03:26:37PM -0700, Luis R. Rodriguez wrote:
> What I meant was that the PCI config space would already have L1
> enabled if L1 worked, so I don't see why we would need to nitpick out
> specifics here. All Atheros PCIE chips should work with L1. The advise
> given is to disable L0s though. I believe AR2425 would be one which
> likely had L0s enabled but requires it to be disabled. Not sure of
> others. But this is why I am saying this can be done globally for all
> ath5k chipsets.
If L1 is set but the chip is pre-PCIe 1.1 then we'll disable L1 unless
the driver tells us that it's functional. The .inf from the Windows
driver seemed to suggest that only a subset of the chips re-enabled L1
there, but if it's ok in general then that's a straightforward one-line
patch.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-07-26 22:29 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 10:09 [PATCH] ath5k: disable ASPM Jussi Kivilinna
2010-05-28 16:19 ` [ath5k-devel] " Pavel Roskin
2010-05-28 18:25 ` Jussi Kivilinna
2010-05-28 20:27 ` Pavel Roskin
2010-05-31 1:06 ` Bruno Randolf
2010-06-01 20:43 ` Luis R. Rodriguez
2010-06-01 20:43 ` Luis R. Rodriguez
2010-05-28 17:40 ` Luis R. Rodriguez
2010-05-28 18:20 ` Jussi Kivilinna
2010-06-17 20:33 ` Maxim Levitsky
2010-06-18 8:20 ` Jussi Kivilinna
2010-06-18 9:09 ` [ath5k-devel] " RHS Linux User
2010-06-18 10:15 ` Maxim Levitsky
2010-06-18 10:49 ` Jussi Kivilinna
2010-06-18 11:05 ` Maxim Levitsky
2010-06-18 11:05 ` Maxim Levitsky
2010-06-18 13:59 ` Bob Copeland
2010-06-18 13:59 ` Bob Copeland
2010-06-18 14:11 ` Maxim Levitsky
2010-06-18 14:11 ` Maxim Levitsky
2010-06-19 7:49 ` [PATCH v2] " Maxim Levitsky
2010-06-19 7:49 ` Maxim Levitsky
2010-06-19 12:38 ` Bob Copeland
2010-06-19 12:38 ` Bob Copeland
2010-06-19 13:02 ` Maxim Levitsky
2010-06-19 13:02 ` Maxim Levitsky
2010-06-19 15:32 ` [PATCH v3] " Maxim Levitsky
2010-06-19 15:32 ` Maxim Levitsky
2010-07-26 20:13 ` [ath5k-devel] " Luis R. Rodriguez
2010-07-26 20:13 ` Luis R. Rodriguez
2010-07-26 20:49 ` Maxim Levitsky
2010-07-26 20:49 ` Maxim Levitsky
2010-07-26 21:06 ` Luis R. Rodriguez
2010-07-26 21:06 ` Luis R. Rodriguez
2010-07-26 21:14 ` Matthew Garrett
2010-07-26 21:14 ` Matthew Garrett
2010-07-26 22:20 ` Luis R. Rodriguez
2010-07-26 22:20 ` Luis R. Rodriguez
2010-07-26 22:24 ` Matthew Garrett
2010-07-26 22:24 ` Matthew Garrett
2010-07-26 22:29 ` Luis R. Rodriguez
2010-07-26 22:29 ` Luis R. Rodriguez
2010-07-26 21:17 ` Maxim Levitsky
2010-07-26 21:17 ` Maxim Levitsky
2010-07-26 21:25 ` Matthew Garrett
2010-07-26 21:25 ` Matthew Garrett
2010-07-26 22:15 ` Luis R. Rodriguez
2010-07-26 22:15 ` Luis R. Rodriguez
2010-07-26 22:21 ` Matthew Garrett
2010-07-26 22:21 ` Matthew Garrett
2010-07-26 22:26 ` Luis R. Rodriguez
2010-07-26 22:26 ` Luis R. Rodriguez
2010-07-26 22:29 ` Matthew Garrett [this message]
2010-07-26 22:29 ` Matthew Garrett
2010-07-26 22:31 ` Luis R. Rodriguez
2010-07-26 22:31 ` Luis R. Rodriguez
2010-07-26 22:33 ` Matthew Garrett
2010-07-26 22:33 ` Matthew Garrett
2010-07-26 22:43 ` Luis R. Rodriguez
2010-07-26 22:43 ` Luis R. Rodriguez
2010-07-26 22:50 ` Matthew Garrett
2010-07-26 22:50 ` Matthew Garrett
2010-07-27 9:35 ` Maxim Levitsky
2010-07-27 9:35 ` Maxim Levitsky
2010-07-27 15:57 ` Luis R. Rodriguez
2010-07-27 15:57 ` Luis R. Rodriguez
2010-07-28 23:48 ` Maxim Levitsky
2010-07-28 23:48 ` Maxim Levitsky
2010-07-29 0:06 ` Luis R. Rodriguez
2010-07-29 0:06 ` Luis R. Rodriguez
2010-07-26 22:13 ` Luis R. Rodriguez
2010-07-26 22:13 ` Luis R. Rodriguez
2010-07-26 22:56 ` Luis R. Rodriguez
2010-07-26 22:56 ` Luis R. Rodriguez
2010-06-20 8:13 ` [ath5k-devel] [PATCH v2] " Luis R. Rodriguez
2010-06-20 8:13 ` Luis R. Rodriguez
2010-06-20 11:18 ` Maxim Levitsky
2010-06-20 11:18 ` Maxim Levitsky
2010-06-20 18:04 ` Maxim Levitsky
2010-06-20 18:04 ` Maxim Levitsky
2010-06-21 5:53 ` Luis R. Rodriguez
2010-06-21 5:53 ` Luis R. Rodriguez
2010-06-21 20:01 ` Jussi Kivilinna
2010-06-21 20:01 ` Jussi Kivilinna
2010-06-21 20:16 ` Maxim Levitsky
2010-06-21 20:16 ` Maxim Levitsky
2010-06-21 20:33 ` Jussi Kivilinna
2010-06-21 20:33 ` Jussi Kivilinna
2010-06-21 20:39 ` Luis R. Rodriguez
2010-06-21 20:39 ` Luis R. Rodriguez
2010-06-22 16:31 ` Matthew Garrett
2010-06-22 16:31 ` Matthew Garrett
2010-06-22 16:48 ` Luis R. Rodriguez
2010-06-22 16:48 ` Luis R. Rodriguez
2010-06-22 16:52 ` Matthew Garrett
2010-06-22 17:17 ` Luis R. Rodriguez
2010-06-22 17:25 ` Matthew Garrett
2010-06-22 17:40 ` Luis R. Rodriguez
2010-06-22 17:50 ` Matthew Garrett
2010-06-22 18:28 ` Luis R. Rodriguez
2010-06-22 18:44 ` Matthew Garrett
2010-06-22 19:13 ` Luis R. Rodriguez
2010-06-22 19:31 ` Johannes Stezenbach
2010-06-22 19:37 ` Luis R. Rodriguez
2010-06-22 19:38 ` Luis R. Rodriguez
2010-06-23 14:39 ` Johannes Stezenbach
2010-06-23 16:28 ` Luis R. Rodriguez
2010-06-23 19:07 ` Johannes Stezenbach
2010-06-23 19:23 ` Johannes Stezenbach
2010-06-21 20:37 ` Luis R. Rodriguez
2010-06-21 20:37 ` Luis R. Rodriguez
2010-06-21 23:55 ` Maxim Levitsky
2010-06-21 23:55 ` Maxim Levitsky
2010-07-26 16:34 ` [PATCH] " Maxim Levitsky
2010-07-26 18:37 ` John W. Linville
2010-07-26 18:41 ` [ath5k-devel] " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100726222909.GA6773@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=David.Quan@atheros.com \
--cc=Luis.Rodriguez@atheros.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jussi.kivilinna@mbnet.fi \
--cc=kernel-team@lists.ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=mcgrof@bombadil.infradead.org \
--cc=mcgrof@gmail.com \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.