All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>,
	adilger@sun.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH][BUG] ext4: do not execute ext4_std_error with EFBIG at ext4_setattr
Date: Mon, 26 Jul 2010 21:09:13 -0400	[thread overview]
Message-ID: <20100727010913.GC14072@thunk.org> (raw)
In-Reply-To: <4C28B8AD.6040001@redhat.com>

On Mon, Jun 28, 2010 at 09:58:53AM -0500, Eric Sandeen wrote:
> Toshiyuki Okajima wrote:
> > From: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
> > 
> > You know, do_truncate() can call ext4_setattr() (via notify_change()).
> > And, ext4_setattr() can return with -EFBIG if the argument(length) of 
> > do_truncate() is more than sbi->s_bitmap_maxbytes. At that time, 
> > it also calls ext4_std_error() with -EFBIG.
> > 
> > Besides, a panic happens when ext4_setattr() returns with -EFBIG
> > after we mount an ext4 filesystem with errors=panic.
> 
> ...
> 
> > This changes prevent this problem from happening.
> 
> Whoops, that one was my fault; thanks for catching it.
> 
> I might just "return error" at that spot, but this works fine too.

I've fixed this by simply returning EFBIG at that spot, since that's a
bit simpler and it reduces the line count to boot.

Toshiyuki-san, thanks for pointing this out!

							- Ted

      reply	other threads:[~2010-07-27  1:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-28  2:42 [PATCH][BUG] ext4: do not execute ext4_std_error with EFBIG at ext4_setattr Toshiyuki Okajima
2010-06-28 14:58 ` Eric Sandeen
2010-07-27  1:09   ` Ted Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100727010913.GC14072@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@sun.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=toshi.okajima@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.