From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] setserial: convert to autotargets and fix bug 2269
Date: Tue, 27 Jul 2010 10:35:06 +0200 [thread overview]
Message-ID: <20100727103506.629d9469@surf> (raw)
In-Reply-To: <87wrshdfhp.fsf@macbook.be.48ers.dk>
On Tue, 27 Jul 2010 00:50:58 +0200
Peter Korsgaard <jacmet@uclibc.org> wrote:
> >>>>> "Thomas" == Thomas Petazzoni
> >>>>> <thomas.petazzoni@free-electrons.com> writes:
>
> Thomas> +Index: setserial-2.17/Makefile.in
> Thomas> +===================================================================
> Thomas> +--- setserial-2.17.orig/Makefile.in
> Thomas> ++++ setserial-2.17/Makefile.in
> Thomas> +@@ -26,9 +26,11 @@
> Thomas> + nroff -man setserial.8 > setserial.cat
> Thomas> +
> Thomas> + install: setserial setserial.8
> Thomas> +- $(INSTALL_PROGRAM) setserial $(DESTDIR)/bin
> Thomas> ++ mkdir -p $(DESTDIR)/usr/bin
> Thomas> ++ $(INSTALL_PROGRAM) setserial $(DESTDIR)/usr/bin
> Thomas> + $(STRIP) $(DESTDIR)/bin/setserial
>
> That strip should go.
Well, it was here in the setserial Makefile. While I agree that we
shouldn't explicitly add strip commands in Buildroot .mk files, I don't
think it's worth the effort removing those strip commands from within
the package.
> You're also not renaming setserial-tiocghayesesp-build-fix.patch, so
> we're back with 5a2844c748.
Right, sorry.
Thanks for having fixed those issues.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-07-27 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 14:53 [Buildroot] [pull request] Pull request for branch genautotargets-conversion Thomas Petazzoni
2010-07-25 14:53 ` [Buildroot] [PATCH 1/4] ltrace: convert to gentargets and bump to 0.5.3 Thomas Petazzoni
2010-07-25 14:53 ` [Buildroot] [PATCH 2/4] tftpd: convert to autotargets Thomas Petazzoni
2010-07-25 14:53 ` [Buildroot] [PATCH 3/4] setserial: convert to autotargets and fix bug 2269 Thomas Petazzoni
2010-07-26 22:50 ` Peter Korsgaard
2010-07-27 8:35 ` Thomas Petazzoni [this message]
2010-07-27 8:53 ` Peter Korsgaard
2010-07-25 14:53 ` [Buildroot] [PATCH 4/4] Deprecate pcmcia and microwin packages Thomas Petazzoni
2010-07-26 22:52 ` [Buildroot] [pull request] Pull request for branch genautotargets-conversion Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727103506.629d9469@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.