From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] Driver-core: Fix bluetooth network device rename regression Date: Tue, 27 Jul 2010 06:49:04 -0700 Message-ID: <20100727134904.GA4994@kroah.com> References: <1279822828.12439.24.camel@jlt3.sipsolutions.net> <20100722182827.GA12821@suse.de> <1279823801.12439.31.camel@jlt3.sipsolutions.net> <20100722185449.GB528@suse.de> <20100726180941.GB4883@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "Eric W. Biederman" , Greg KH , Johannes Berg , Andrew Morton , "Rafael J. Wysocki" , "Maciej W. Rozycki" , netdev To: Kay Sievers Return-path: Received: from kroah.org ([198.145.64.141]:53881 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753673Ab0G0Nt5 (ORCPT ); Tue, 27 Jul 2010 09:49:57 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jul 27, 2010 at 11:10:26AM +0200, Kay Sievers wrote: > On Mon, Jul 26, 2010 at 20:09, Greg KH wrote: > >> Does this version of the change look less bleh worthy? =A0The effe= ct is > >> the same as my previous patch but the test is more abstract so the > >> effect is not strictly limited to /sys/class/net. > > > > What other class type has a namespace at this point in time? > > Essentially this is the same exact thing, just in a different forma= t > > that obfuscates what you are really doing here. >=20 > The patch still looks broken, and does not belong into the core the > way it is done. We denied hacks like this for good reason. But > out-of-the-blue it was a bluetooth naming regression to fix in the > driver core? Interesting! >=20 > If someone is going to add namespaces to 'block' or 'input', the sysf= s > layout will break, and userspace will be unable to handle the > resulting changes. When that happens, I'm sure Eric will be willing to fix up any problems that are found as he is the one that insisted on pushing it to Linus around our objections. Right Eric? And Eric, where are you working on the "real" patches to solve the problems of the bnet and wireless driver problems so we can remove this check from the driver core as soon as possible? Any idea when they wil= l be done? thanks, greg k-h