From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: don't print scary messages for allocation failures post-abort
Date: Tue, 27 Jul 2010 09:56:16 -0400 [thread overview]
Message-ID: <20100727135616.GF18966@thunk.org> (raw)
In-Reply-To: <4C4DE314.6030100@redhat.com>
On Mon, Jul 26, 2010 at 02:33:40PM -0500, Eric Sandeen wrote:
> I often get emails containing the "This should not happen!!" message,
> conveniently trimmed to remove things like:
>
> sd 0:0:0:0: [sda] Unhandled error code
> sd 0:0:0:0: [sda] Result: hostbyte=DID_OK driverbyte=DRIVER_TIMEOUT
> sd 0:0:0:0: [sda] CDB: Write(10): 2a 00 03 13 c9 70 00 00 28 00
> end_request: I/O error, dev sda, sector 51628400
> Aborting journal on device dm-0-8.
> EXT4-fs error (device dm-0): ext4_journal_start_sb: Detected aborted journal
> EXT4-fs (dm-0): Remounting filesystem read-only
>
> I don't think there is any value to the verbosity if the reason is
> due to a filesystem abort; it just obfuscates the root cause.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
I've added this patch to the ext4 patch queue, thanks.
- Ted
prev parent reply other threads:[~2010-07-27 13:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 19:33 [PATCH] ext4: don't print scary messages for allocation failures post-abort Eric Sandeen
2010-07-27 13:56 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727135616.GF18966@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.