From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH 1/2] ASoC: tlv320dac33: Revisit the FIFO Mode1 handling
Date: Tue, 27 Jul 2010 09:32:44 -0700 [thread overview]
Message-ID: <20100727163243.GA18884@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1280213177-15439-2-git-send-email-peter.ujfalusi@nokia.com>
On Tue, Jul 27, 2010 at 09:46:16AM +0300, Peter Ujfalusi wrote:
> Replace the hardwired latency definition with platform data
> parameter, and simplify the nSample parameter calculation.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
I did notice that the default changes from 20ms:
> -#define LATENCY_TIME_MS 20
> + if (!dac33->mode1_i2c_latency)
> + dac33->mode1_i2c_latency = 10000; /* 10ms */
to 10ms with the new code but that shouldn't be a problem.
next prev parent reply other threads:[~2010-07-27 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 6:46 [PATCH 0/2] ASoC: tlv320dac33: FIFO mode updates Peter Ujfalusi
2010-07-27 6:46 ` [PATCH 1/2] ASoC: tlv320dac33: Revisit the FIFO Mode1 handling Peter Ujfalusi
2010-07-27 16:32 ` Mark Brown [this message]
2010-07-28 5:08 ` Peter Ujfalusi
2010-07-27 6:46 ` [PATCH 2/2] ASoC: tlv320dac33: Add support for automatic FIFO configuration Peter Ujfalusi
2010-07-27 16:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727163243.GA18884@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.