From: Greg KH <greg@kroah.com>
To: Alan Cox <alan@linux.intel.com>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH 3/6] mrst-touchscreen: Fix use before initialize in mrst_touch [Fix bug 2561]
Date: Tue, 27 Jul 2010 11:17:04 -0700 [thread overview]
Message-ID: <20100727181704.GA29234@kroah.com> (raw)
In-Reply-To: <20100723135210.19151.19238.stgit@localhost.localdomain>
On Fri, Jul 23, 2010 at 02:52:12PM +0100, Alan Cox wrote:
> From: Arjan van de Ven <arjan@linux.intel.com>
>
> The mrst touch screen driver, in mrstouch_adc_init does
>
> dev_err(&tsdev->spi->dev, "Unable to read PMIC id\n");
>
> which does not work very well since the tsdev->spi member does not get
> initialized until after the call to mrstouch_adc_init
>
> this patch makes sure the ->spi member is initialized prior to the call
> to mrstouch_adc_init
>
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
Why are there 3 patches attached to this email, all a bit different?
Care to resend this one so I know which to apply?
thanks,
greg k-h
next prev parent reply other threads:[~2010-07-27 18:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 13:51 [PATCH 0/6] Complete the mrst touchscreen tidy Alan Cox
2010-07-23 13:51 ` [PATCH 1/6] mrst_touchscreen: clean up input side Alan Cox
2010-07-27 18:18 ` [PATCH 1/6] Staging: " Greg KH
2010-08-25 14:46 ` Dmitry Torokhov
2010-07-23 13:52 ` [PATCH 2/6] Input: mrst - more fixes Alan Cox
2010-07-23 13:52 ` [PATCH 3/6] mrst-touchscreen: Fix use before initialize in mrst_touch [Fix bug 2561] Alan Cox
2010-07-27 18:17 ` Greg KH [this message]
2010-07-23 13:52 ` [PATCH 4/6] * Register platform interface Alan Cox
2010-07-23 16:07 ` Dmitry Torokhov
2010-07-23 15:38 ` Alan Cox
2010-07-23 16:43 ` Dmitry Torokhov
2010-07-26 22:49 ` Greg KH
2010-07-27 8:16 ` Dmitry Torokhov
2010-07-27 15:22 ` Greg KH
2010-07-23 13:52 ` [PATCH 5/6] fix channel allocation in the touch screen driver Alan Cox
2010-07-23 13:52 ` [PATCH 6/6] Simplify en/disable of interrupts for NEC Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727181704.GA29234@kroah.com \
--to=greg@kroah.com \
--cc=alan@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.