From: "John W. Linville" <linville@tuxdriver.com>
To: Joe Perches <joe@perches.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/4] wireless: Convert wiphy_debug macro to function
Date: Tue, 27 Jul 2010 14:57:28 -0400 [thread overview]
Message-ID: <20100727185728.GF31694@tuxdriver.com> (raw)
In-Reply-To: <1280255665.2082.119.camel@Joe-Laptop.home>
On Tue, Jul 27, 2010 at 11:34:25AM -0700, Joe Perches wrote:
> On Tue, 2010-07-27 at 14:05 -0400, John W. Linville wrote:
> > > --- a/net/wireless/core.c
> > > +++ b/net/wireless/core.c
> > > @@ -907,3 +907,56 @@ static void __exit cfg80211_exit(void)
> > > destroy_workqueue(cfg80211_wq);
> > > }
> > > module_exit(cfg80211_exit);
> > > +
> > > +#ifdef __KERNEL__
> >
> > Do we need this part?
>
> No, not really.
>
> I'm not too sure about the need for the added
> cfg80211.h #ifdef __KERNEL__ either.
Good point -- I'll remove both of them.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2010-07-27 19:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 21:39 [PATCH net-next 0/4] wireless: Add and use wiphy_<level> logging macros Joe Perches
2010-07-26 21:39 ` [PATCH net-next 1/4] include/net/cfg80211.h: Add wiphy_<level> printk equivalents Joe Perches
2010-07-26 21:39 ` [PATCH net-next 2/4] drivers/net/wireless: Use wiphy_<level> Joe Perches
2010-07-26 21:39 ` Joe Perches
2010-07-26 21:39 ` [PATCH net-next 3/4] drivers/net/wireless/at76c50x-usb.c: Neaten macros Joe Perches
2010-07-26 21:40 ` [PATCH net-next 4/4] wireless: Convert wiphy_debug macro to function Joe Perches
2010-07-27 18:05 ` John W. Linville
2010-07-27 18:34 ` Joe Perches
2010-07-27 18:57 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727185728.GF31694@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.