diff for duplicates of <20100727192856.63edc8e0@wker> diff --git a/a/1.txt b/N1/1.txt index 931ecab..8e108c3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,11 @@ On Tue, 27 Jul 2010 10:58:33 -0600 -Grant Likely <grant.likely@secretlab.ca> wrote: +Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote: ... -> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 spi@11900 { -> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D "fsl,mp= -c5121-psc-spi", "fsl,mpc5121-psc"; -> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 cell-index =3D <9>; +> >> > + spi@11900 { +> >> > + compatible = "fsl,mpc5121-psc-spi", "fsl,mpc5121-psc"; +> >> > + cell-index = <9>; > >> -> >> Try to drop the cell-index properties. =A0They are almost always misus= -ed. +> >> Try to drop the cell-index properties. They are almost always misused. > > > > Removing cell-index would require changing the spi driver's probe. > > Currently cell-index is used to set spi bus number. What could be used @@ -15,7 +13,7 @@ ed. > > address? e.g. obtaining the offset 0x11900, masking out the unrelated > > bits and shifting by 8 would deliver unique index 9 for PSC9 in SPI > > mode. This would work for all 12 PSC SPI controllers of mpc5121. ->=20 +> > Does the spi bus number really matter? The device tree context gives > you a firm association between spi masters and devices which doesn't > require assigning a specific bus number. The core spi code can @@ -31,12 +29,12 @@ change to the spi driver. > > nodes of the spi master node. I have already send the appropriate > > patch to spi-devel list, but it is not the right approach to call > > of_register_spi_devices() in each driver. ->=20 +> > It's not wrong; but it isn't ideal either. ->=20 +> > > Do you plan to fix it in > > core spi code in v2.6.36? ->=20 +> > Apparently I no longer have to because you've gone ahead and done it > for me anyway. :-) I'll take a look at that patch and send you my > comments. diff --git a/a/content_digest b/N1/content_digest index 3dcaa82..bc6f8dc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,28 +3,27 @@ "ref\0AANLkTi=Ee6HR+Ux0g4V1+81DXUmsO=UDhi6jWsDgGchv@mail.gmail.com\0" "ref\020100727123647.0a3b8832@wker\0" "ref\0AANLkTika=KeKcaY_FF8tN5Fy-H+cozjZsGObXoQhKiVh@mail.gmail.com\0" - "From\0Anatolij Gustschin <agust@denx.de>\0" + "ref\0AANLkTika=KeKcaY_FF8tN5Fy-H+cozjZsGObXoQhKiVh-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org\0" + "From\0Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>\0" "Subject\0Re: [PATCH v3 2/2] powerpc/mpc5121: add initial support for PDM360NG board\0" "Date\0Tue, 27 Jul 2010 19:28:56 +0200\0" - "To\0Grant Likely <grant.likely@secretlab.ca>\0" - "Cc\0Detlev Zundel <dzu@denx.de>" - Markus Fischer <markus.fischer.ec@ifm.com> - devicetree-discuss@lists.ozlabs.org - Michael Weiss <michael.weiss@ifm.com> - linuxppc-dev@ozlabs.org - " Wolfgang Grandegger <wg@denx.de>\0" + "To\0Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>\0" + "Cc\0Detlev Zundel <dzu-ynQEQJNshbs@public.gmane.org>" + Markus Fischer <markus.fischer.ec-Jj5Fu8i2Z9Q@public.gmane.org> + devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org + Michael Weiss <michael.weiss-Jj5Fu8i2Z9Q@public.gmane.org> + linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org + " Wolfgang Grandegger <wg-ynQEQJNshbs@public.gmane.org>\0" "\00:1\0" "b\0" "On Tue, 27 Jul 2010 10:58:33 -0600\n" - "Grant Likely <grant.likely@secretlab.ca> wrote:\n" + "Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> wrote:\n" "...\n" - "> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 spi@11900 {\n" - "> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 compatible =3D \"fsl,mp=\n" - "c5121-psc-spi\", \"fsl,mpc5121-psc\";\n" - "> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 cell-index =3D <9>;\n" + "> >> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 spi@11900 {\n" + "> >> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 compatible = \"fsl,mpc5121-psc-spi\", \"fsl,mpc5121-psc\";\n" + "> >> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 cell-index = <9>;\n" "> >>\n" - "> >> Try to drop the cell-index properties. =A0They are almost always misus=\n" - "ed.\n" + "> >> Try to drop the cell-index properties. \302\240They are almost always misused.\n" "> >\n" "> > Removing cell-index would require changing the spi driver's probe.\n" "> > Currently cell-index is used to set spi bus number. What could be used\n" @@ -32,7 +31,7 @@ "> > address? e.g. obtaining the offset 0x11900, masking out the unrelated\n" "> > bits and shifting by 8 would deliver unique index 9 for PSC9 in SPI\n" "> > mode. This would work for all 12 PSC SPI controllers of mpc5121.\n" - ">=20\n" + "> \n" "> Does the spi bus number really matter? The device tree context gives\n" "> you a firm association between spi masters and devices which doesn't\n" "> require assigning a specific bus number. The core spi code can\n" @@ -48,12 +47,12 @@ "> > nodes of the spi master node. I have already send the appropriate\n" "> > patch to spi-devel list, but it is not the right approach to call\n" "> > of_register_spi_devices() in each driver.\n" - ">=20\n" + "> \n" "> It's not wrong; but it isn't ideal either.\n" - ">=20\n" + "> \n" "> > Do you plan to fix it in\n" "> > core spi code in v2.6.36?\n" - ">=20\n" + "> \n" "> Apparently I no longer have to because you've gone ahead and done it\n" "> for me anyway. :-) I'll take a look at that patch and send you my\n" "> comments.\n" @@ -61,4 +60,4 @@ "Okay, thanks,\n" Anatolij -f3150409dbe9ae15cd9af42ee3ee7401374fe9eebe1033666843f2d96dafabb9 +b2e4b3219efa3707054896c9043aab24a01717dd5b07d7c6a7e84597713ee94d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.