From: Marcelo Tosatti <mtosatti@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, ddutile@redhat.com, chrisw@redhat.com
Subject: Re: [PATCH v4] device-assignment: Use PCI I/O port sysfs resource file when available
Date: Tue, 27 Jul 2010 17:37:44 -0300 [thread overview]
Message-ID: <20100727203744.GA31991@amt.cnet> (raw)
In-Reply-To: <20100723214454.21633.93017.stgit@localhost6.localdomain6>
On Fri, Jul 23, 2010 at 03:47:18PM -0600, Alex Williamson wrote:
> When supported by the host kernel, we can use read/write on the
> PCI sysfs resource file for I/O port regions. This allows us to
> avoid raw in/out commands and works with deprivileged guests via
> libvirt.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>
> Required kernel patch pending here:
> http://www.spinics.net/lists/linux-pci/msg09389.html
>
> v4: Remove commit sentence about uid since we removed the code
> in v2. Identical patch to v3. Also note preliminary
> agreement to include kerenl patch:
> http://www.spinics.net/lists/linux-pci/msg09412.html
>
> v3: Fixup sysfs errno checking, anything except EINVAL should fall
> back to in/out. This covers things like EPERM on the resource
> file too.
>
> v2: Drop getuid() since it doesn't guarantee permissions
> Don't use in/out as a fallback since we don't have permissions
> Consolidate ioport read/write functions
>
> hw/device-assignment.c | 201 +++++++++++++++++++++++++++---------------------
> hw/device-assignment.h | 1
> 2 files changed, 116 insertions(+), 86 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2010-07-27 21:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 22:11 [PATCH] device-assignment: Use PCI I/O port sysfs resource file when available Alex Williamson
2010-07-20 23:13 ` Chris Wright
2010-07-21 8:17 ` Daniel P. Berrange
2010-07-21 3:30 ` [PATCH v2] " Alex Williamson
2010-07-21 14:24 ` [PATCH v3] " Alex Williamson
2010-07-23 21:47 ` [PATCH v4] " Alex Williamson
2010-07-23 23:01 ` Chris Wright
2010-07-27 20:37 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727203744.GA31991@amt.cnet \
--to=mtosatti@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=chrisw@redhat.com \
--cc=ddutile@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.