diff for duplicates of <20100728095655.0e1c81eb@wker> diff --git a/a/1.txt b/N1/1.txt index 7e12144..11db4bd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,16 +1,18 @@ On Wed, 28 Jul 2010 01:02:59 -0600 Grant Likely <grant.likely@secretlab.ca> wrote: ... -> > drivers/video/fsl-diu-fb.c | 38 +++++++++++++++++++++++--------------- -> > 1 files changed, 23 insertions(+), 15 deletions(-) +> > =C2=A0drivers/video/fsl-diu-fb.c | =C2=A0 38 +++++++++++++++++++++++---= +------------ +> > =C2=A01 files changed, 23 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c > > index 27455ce..9b8c991 100644 > > --- a/drivers/video/fsl-diu-fb.c > > +++ b/drivers/video/fsl-diu-fb.c > > @@ -317,6 +317,17 @@ static void fsl_diu_free(void *virt, size_t size) -> > free_pages_exact(virt, size); -> > } +> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0free_pages_exact= +(virt, size); +> > =C2=A0} > > > > +/* > > + * Workaround for failed writing desc register of planes. @@ -18,11 +20,11 @@ Grant Likely <grant.likely@secretlab.ca> wrote: > > + */ > > +void wr_reg_wa(u32 *reg, u32 val) > > +{ -> > + do { -> > + out_be32(reg, val); -> > + } while (in_be32(reg) != val); +> > + =C2=A0 =C2=A0 =C2=A0 do { +> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 out_be32(reg, val); +> > + =C2=A0 =C2=A0 =C2=A0 } while (in_be32(reg) !=3D val); > > +} -> +>=20 > I'll apply this one, but it looks like a potential problem. What > happens if the write never succeeds? The kernel then gets stuck in a > forever busy loop. You should look at reworking it. diff --git a/a/content_digest b/N1/content_digest index 7a70c17..05b8015 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,31 +1,32 @@ "ref\01279893639-24333-1-git-send-email-agust@denx.de\0" "ref\01279893639-24333-2-git-send-email-agust@denx.de\0" "ref\0AANLkTikkLVCxU4ZC_nmUhKTQogUNeQzxOX6KqgZcxiYr@mail.gmail.com\0" - "ref\0AANLkTikkLVCxU4ZC_nmUhKTQogUNeQzxOX6KqgZcxiYr-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org\0" "From\0Anatolij Gustschin <agust@denx.de>\0" - "Subject\0Re: [PATCH v4 1/5] fsl-diu-fb: fix issue with re-enabling DIU area\0" - "Date\0Wed, 28 Jul 2010 07:56:55 +0000\0" - "To\0Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>\0" - "Cc\0linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org" - linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org - Detlev Zundel <dzu-ynQEQJNshbs@public.gmane.org> - " Wolfgang Denk <wd-ynQEQJNshbs@public.gmane.org>\0" + "Subject\0Re: [PATCH v4 1/5] fsl-diu-fb: fix issue with re-enabling DIU area descriptor\0" + "Date\0Wed, 28 Jul 2010 09:56:55 +0200\0" + "To\0Grant Likely <grant.likely@secretlab.ca>\0" + "Cc\0linuxppc-dev@ozlabs.org" + linux-fbdev@vger.kernel.org + devicetree-discuss@lists.ozlabs.org + Detlev Zundel <dzu@denx.de> + " Wolfgang Denk <wd@denx.de>\0" "\00:1\0" "b\0" "On Wed, 28 Jul 2010 01:02:59 -0600\n" "Grant Likely <grant.likely@secretlab.ca> wrote:\n" "...\n" - "> > \302\240drivers/video/fsl-diu-fb.c | \302\240 38 +++++++++++++++++++++++---------------\n" - "> > \302\2401 files changed, 23 insertions(+), 15 deletions(-)\n" + "> > =C2=A0drivers/video/fsl-diu-fb.c | =C2=A0 38 +++++++++++++++++++++++---=\n" + "------------\n" + "> > =C2=A01 files changed, 23 insertions(+), 15 deletions(-)\n" "> >\n" "> > diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c\n" "> > index 27455ce..9b8c991 100644\n" "> > --- a/drivers/video/fsl-diu-fb.c\n" "> > +++ b/drivers/video/fsl-diu-fb.c\n" "> > @@ -317,6 +317,17 @@ static void fsl_diu_free(void *virt, size_t size)\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240free_pages_exact(virt, size);\n" - "> > \302\240}\n" + "> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0free_pages_exact=\n" + "(virt, size);\n" + "> > =C2=A0}\n" "> >\n" "> > +/*\n" "> > + * Workaround for failed writing desc register of planes.\n" @@ -33,11 +34,11 @@ "> > + */\n" "> > +void wr_reg_wa(u32 *reg, u32 val)\n" "> > +{\n" - "> > + \302\240 \302\240 \302\240 do {\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 out_be32(reg, val);\n" - "> > + \302\240 \302\240 \302\240 } while (in_be32(reg) != val);\n" + "> > + =C2=A0 =C2=A0 =C2=A0 do {\n" + "> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 out_be32(reg, val);\n" + "> > + =C2=A0 =C2=A0 =C2=A0 } while (in_be32(reg) !=3D val);\n" "> > +}\n" - "> \n" + ">=20\n" "> I'll apply this one, but it looks like a potential problem. What\n" "> happens if the write never succeeds? The kernel then gets stuck in a\n" "> forever busy loop. You should look at reworking it.\n" @@ -47,4 +48,4 @@ "\n" Anatolij -d4a0fd8f1e6828e346d12762548e8d3b73d5d79320c747faef9f16eb38549140 +c436b2d338570f61cd2a559ccc2a3a83ef7d34438647fb79e0389a27295ca6a8
diff --git a/a/1.txt b/N2/1.txt index 7e12144..684906b 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -31,3 +31,7 @@ I'll submit an incremental patch that prevents looping forever in the case if the write never succeeds. Thanks! Anatolij +_______________________________________________ +devicetree-discuss mailing list +devicetree-discuss@lists.ozlabs.org +https://lists.ozlabs.org/listinfo/devicetree-discuss diff --git a/a/content_digest b/N2/content_digest index 7a70c17..754c64c 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,9 +2,9 @@ "ref\01279893639-24333-2-git-send-email-agust@denx.de\0" "ref\0AANLkTikkLVCxU4ZC_nmUhKTQogUNeQzxOX6KqgZcxiYr@mail.gmail.com\0" "ref\0AANLkTikkLVCxU4ZC_nmUhKTQogUNeQzxOX6KqgZcxiYr-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org\0" - "From\0Anatolij Gustschin <agust@denx.de>\0" - "Subject\0Re: [PATCH v4 1/5] fsl-diu-fb: fix issue with re-enabling DIU area\0" - "Date\0Wed, 28 Jul 2010 07:56:55 +0000\0" + "From\0Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>\0" + "Subject\0Re: [PATCH v4 1/5] fsl-diu-fb: fix issue with re-enabling DIU area descriptor\0" + "Date\0Wed, 28 Jul 2010 09:56:55 +0200\0" "To\0Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>\0" "Cc\0linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org" linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org @@ -45,6 +45,10 @@ "I'll submit an incremental patch that prevents looping forever in\n" "the case if the write never succeeds. Thanks!\n" "\n" - Anatolij + "Anatolij\n" + "_______________________________________________\n" + "devicetree-discuss mailing list\n" + "devicetree-discuss@lists.ozlabs.org\n" + https://lists.ozlabs.org/listinfo/devicetree-discuss -d4a0fd8f1e6828e346d12762548e8d3b73d5d79320c747faef9f16eb38549140 +b6ed6077b7e7389ca831b49842e2e8e514954da680df06daef5e3cdd79aa95d5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.