All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: lirc-list@lists.sourceforge.net,
	Jarod Wilson <jarod@wilsonet.com>,
	linux-input@vger.kernel.org, linux-media@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: [PATCH 1/9] IR: Kconfig fixes
Date: Wed, 28 Jul 2010 10:36:17 -0700	[thread overview]
Message-ID: <20100728103617.4b0207b9.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1280330051-27732-2-git-send-email-maximlevitsky@gmail.com>

On Wed, 28 Jul 2010 18:14:03 +0300 Maxim Levitsky wrote:

> Move IR drives below separate menu.
> This allows to disable them.
> Also correct a typo.
> 
> Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
> ---
>  drivers/media/IR/Kconfig |   14 +++++++++++---
>  1 files changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/IR/Kconfig b/drivers/media/IR/Kconfig
> index e557ae0..99ea9cd 100644
> --- a/drivers/media/IR/Kconfig
> +++ b/drivers/media/IR/Kconfig
> @@ -1,8 +1,10 @@
> -config IR_CORE
> -	tristate
> +menuconfig IR_CORE
> +	tristate "Infrared remote controller adapters"
>  	depends on INPUT
>  	default INPUT
>  
> +if IR_CORE
> +
>  config VIDEO_IR
>  	tristate
>  	depends on IR_CORE
> @@ -16,7 +18,7 @@ config LIRC
>  	   Enable this option to build the Linux Infrared Remote
>  	   Control (LIRC) core device interface driver. The LIRC
>  	   interface passes raw IR to and from userspace, where the
> -	   LIRC daemon handles protocol decoding for IR reception ann
> +	   LIRC daemon handles protocol decoding for IR reception and
>  	   encoding for IR transmitting (aka "blasting").
>  
>  source "drivers/media/IR/keymaps/Kconfig"
> @@ -102,3 +104,9 @@ config IR_MCEUSB
>  
>  	   To compile this driver as a module, choose M here: the
>  	   module will be called mceusb.
> +
> +
> +
> +
> +
> +endif #IR_CORE

I don't think that those extra blank lines are a fix...

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2010-07-28 17:37 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 15:14 [PATCH 0/9 v1] IR: few fixes, additions and ENE driver Maxim Levitsky
2010-07-28 15:14 ` [PATCH 1/9] IR: Kconfig fixes Maxim Levitsky
2010-07-28 17:36   ` Randy Dunlap [this message]
2010-07-28 20:31     ` Maxim Levitsky
2010-07-28 15:14 ` [PATCH 2/9] IR: minor fixes: Maxim Levitsky
2010-07-28 16:01   ` Mauro Carvalho Chehab
2010-07-28 16:38     ` Maxim Levitsky
2010-07-28 17:59       ` Mauro Carvalho Chehab
2010-07-28 17:23   ` Jarod Wilson
2010-07-28 15:14 ` [PATCH 3/9] IR: replace spinlock with mutex Maxim Levitsky
2010-07-28 16:03   ` Mauro Carvalho Chehab
2010-07-28 16:32     ` Maxim Levitsky
2010-07-28 17:43       ` Jarod Wilson
2010-07-28 18:37         ` Mauro Carvalho Chehab
2010-07-28 15:14 ` [PATCH 4/9] IR: add helper functions for ir input devices that send ir timing data in small chunks, and alternation between pulses and spaces isn't guaranteed Maxim Levitsky
2010-07-28 16:09   ` Mauro Carvalho Chehab
2010-07-28 16:29     ` Maxim Levitsky
2010-07-28 17:46   ` Jarod Wilson
2010-07-28 20:57     ` Jarod Wilson
2010-07-28 21:16       ` Maxim Levitsky
2010-07-28 15:14 ` [PATCH 5/9] IR: extend interfaces to support more device settings Maxim Levitsky
2010-07-28 17:00   ` Mauro Carvalho Chehab
2010-07-28 20:47   ` Jarod Wilson
2010-07-28 15:14 ` [PATCH 6/9] IR: actually allow not to compile keymaps in Maxim Levitsky
2010-07-28 17:58   ` Jarod Wilson
2010-07-28 15:14 ` [PATCH 7/9] IR: actualy report unknown scancodes the in-kernel decoders found Maxim Levitsky
2010-07-28 15:14 ` [PATCH 8/9] IR: Add ENE input driver Maxim Levitsky
2010-07-28 17:10   ` Mauro Carvalho Chehab
2010-07-28 17:13     ` Maxim Levitsky
2010-07-28 17:17       ` Jarod Wilson
2010-07-28 18:13       ` Mauro Carvalho Chehab
2010-07-28 15:14 ` [PATCH 9/9] STAGING: remove ENE driver Maxim Levitsky
  -- strict thread matches above, loose matches on Subject: below --
2010-07-28 23:40 (unknown), Maxim Levitsky
2010-07-28 23:40 ` [PATCH 1/9] IR: Kconfig fixes Maxim Levitsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100728103617.4b0207b9.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=jarod@wilsonet.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lirc-list@lists.sourceforge.net \
    --cc=maximlevitsky@gmail.com \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.