From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH 5/6] libxl: portiblity fixes Date: Wed, 28 Jul 2010 11:17:30 +0200 Message-ID: <201007281117.30893.Christoph.Egger@amd.com> References: <201007201831.21416.Christoph.Egger@amd.com> <201007271420.01834.Christoph.Egger@amd.com> <19535.4247.736271.509457@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19535.4247.736271.509457@mariner.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "xen-devel@lists.xensource.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Tuesday 27 July 2010 19:00:07 Ian Jackson wrote: > Christoph Egger writes ("[Xen-devel] [PATCH 5/6] libxl: portiblity fixes"): > > LIBXL_OBJS-y = osdeps.o libxl_paths.o libxl_bootloader.o > > +LIBXL_OBJS-$(CONFIG_Linux) += libxl_linux.o > > +LIBXL_OBJS-$(CONFIG_NetBSD) += libxl_netbsd.o > > As previously discussed, these files should probably be called > libxl_blktap2.c and libxl_noblktap2.c or some such. Discussed between you and Ian Campell. Both of you believe that blktap support on NetBSD will never exist, right ? blktap support for NetBSD is under development and will be very different in its implementation. > > +const char *libxl_blktap_devpath(struct libxl_ctx *ctx, > > + const char *disk, > > + libxl_disk_phystype phystype) > > You seem to be moving code about by adding it in one patch and > deleting it in another; In this case I call this 'factor out OS dependent code'. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632