From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com, Alasdair G Kergon <agk@redhat.com>
Subject: [PATCH 1.5/2 v2] dm stripe: optimize sector division
Date: Wed, 28 Jul 2010 11:21:04 -0400 [thread overview]
Message-ID: <20100728152104.GA5607@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1007281029440.22479@hs20-bc2-1.build.redhat.com>
From: Mikulas Patocka <mpatocka@redhat.com>
Optimize sector division --- if the number of stripes is a power of two,
we don't have to do expensive division and can do shift and mask instead.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
---
drivers/md/dm-stripe.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
v2: minor code cleanup in stripe_map_sector
Index: linux-2.6-block/drivers/md/dm-stripe.c
===================================================================
--- linux-2.6-block.orig/drivers/md/dm-stripe.c
+++ linux-2.6-block/drivers/md/dm-stripe.c
@@ -25,6 +25,7 @@ struct stripe {
struct stripe_c {
uint32_t stripes;
+ int stripes_shift;
/* The size of this target / num. stripes */
sector_t stripe_width;
@@ -164,6 +165,10 @@ static int stripe_ctr(struct dm_target *
sc->ti = ti;
sc->stripes = stripes;
+ if (!(stripes & (stripes - 1)))
+ sc->stripes_shift = ffs(stripes) - 1;
+ else
+ sc->stripes_shift = -1;
sc->stripe_width = width;
ti->split_io = chunk_size;
ti->num_flush_requests = stripes;
@@ -213,7 +218,12 @@ static void stripe_map_sector(struct str
{
sector_t offset = sector - sc->ti->begin;
sector_t chunk = offset >> sc->chunk_shift;
- *stripe = sector_div(chunk, sc->stripes);
+
+ if (likely(sc->stripes_shift >= 0)) {
+ *stripe = chunk & ((1 << sc->stripes_shift) - 1);
+ chunk >>= sc->stripes_shift;
+ } else
+ *stripe = sector_div(chunk, sc->stripes);
*result = (chunk << sc->chunk_shift) | (offset & sc->chunk_mask);
}
next prev parent reply other threads:[~2010-07-28 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 21:38 [PATCH 1/2] dm-stripe: move sector translation to a function Mikulas Patocka
2010-07-27 21:42 ` [PATCH 2/2] dm-stripe: discard support Mikulas Patocka
2010-07-27 22:12 ` [PATCH 1.5/2] dm-stripe: optimize sector division Mikulas Patocka
2010-07-27 23:10 ` Mike Snitzer
2010-07-28 13:53 ` Mike Snitzer
2010-07-28 14:43 ` Mikulas Patocka
2010-07-28 15:21 ` Mike Snitzer [this message]
2010-07-27 22:39 ` [PATCH 2/2] dm-stripe: discard support Mike Snitzer
2010-07-28 0:03 ` [PATCH 2/2 v2] dm stripe: enable " Mike Snitzer
2010-07-28 0:06 ` Mike Snitzer
2010-07-28 17:09 ` [PATCH 1/2 v2] dm stripe: move sector translation to a function Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100728152104.GA5607@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.