From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] xenpaging: correct order of linker options
 to avoid link errors with recent toolchains
Date: Wed, 28 Jul 2010 18:15:24 +0200
Message-ID: <20100728161524.GA7525@aepfle.de>
References: <20100728125517.GB1949@aepfle.de>
	<19536.14440.565355.587038@mariner.uk.xensource.com>
	<20100728154750.GA6899@aepfle.de>
	<19536.21860.12916.94743@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <19536.21860.12916.94743@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, Jul 28, Ian Jackson wrote:

> Olaf Hering writes ("[PATCH] xenpaging: correct order of linker options to avoid link errors with recent toolchains"):
> > -LDFLAGS  += $(LDFLAGS_libxenctrl) $(LDFLAGS_libxenstore)
> > +XENPAGING_LIBS = $(LDFLAGS_libxenctrl) $(LDFLAGS_libxenstore)
> 
> *_LIBS = $(LDFLAGS_*)  ?
> 
> surely some mistake.

Ian,

LDFLAGS_libxenctrl is defined in tools/Rules.mk and used in several
Makefiles. Are you suggesting to rename these variables and update all
users?


Also, its not clear to me why the place of LDFLAGS matters. In another
thread it was stated that -static may behave different. Whats the reason
for that?

Olaf