Re: [PATCH 2/2] iw: Add antenna configuration commands

[Bruno Randolf <br1@einfach.org>]

On Wed July 28 2010 15:50:48 Johannes Berg wrote:
> On Wed, 2010-07-28 at 11:07 +0900, Bruno Randolf wrote:
> > On Tue July 27 2010 19:04:21 Johannes Berg wrote:
> > > On Tue, 2010-07-27 at 18:49 +0900, Bruno Randolf wrote:
> > > > +	if (tb_msg[NL80211_ATTR_WIPHY_ANTENNA_TX] &&
> > > > +	    tb_msg[NL80211_ATTR_WIPHY_ANTENNA_RX]) {
> > > > +		printf("\tAntenna: TX %d RX %d\n",
> > > > +		       nla_get_u8(tb_msg[NL80211_ATTR_WIPHY_ANTENNA_TX]),
> > > > +		       nla_get_u8(tb_msg[NL80211_ATTR_WIPHY_ANTENNA_RX]));
> > > 
> > > That's like the worst possible way to show the info.
> > 
> > which way would you prefer?
> 
> It occurred to me later that with the normal numbers we have (1 through
> 7) it won't matter much ... but still, I'd prefer %#x.

ok. changed that and the command line parsing to use "strtoul(argv[1], &end, 
0)" so we can use hex, decimal or octal for the setting. i will resend the 
patches once a consensus is reached (or after an unspecified timeout ;)).

bruno