All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/12 v4] Clean up linux-user/elfload.c
Date: Thu, 29 Jul 2010 09:09:41 +0200	[thread overview]
Message-ID: <20100729070941.GA16888@laped.lan> (raw)
In-Reply-To: <1280251538-6860-1-git-send-email-rth@twiddle.net>

On Tue, Jul 27, 2010 at 10:25:26AM -0700, Richard Henderson wrote:
> A re-based and re-tested version of a patch series I
> posted back in April and May.  These cleanups prepare
> elfload.c for loading the VDSO for x86_64.

I got a whitespace warning when applying the patches:
Applying: linux-user: Reduce lseek+reads while loading elf files.
/home/edgar/src/c/qemu/git/qemu/.git/rebase-apply/patch:219: trailing whitespace.
/* Read a good amount of data initially, to hopefully get all the 
warning: 1 line adds whitespace errors.


I removed the trailing whitespace and fixed the interpreter less
ELF loading on my side and applied the series.

If there are more issues with the pre-existing realloc malc
commented on, I think those can be handled with follow up patches.

Thanks,
Edgar



> 
> 
> r~
> 
> 
> Richard Henderson (12):
>   linux-user: Handle filesz < memsz for any PT_LOAD segment.
>   Add more DT_* and AT_* constants to qemu's copy of elf.h.
>   linux-user: Reindent elfload.c.
>   linux-user: Reduce lseek+reads while loading elf files.
>   linux-user: Define ELF_DATA generically.
>   linux-user: Clean up byte-swapping in elfload.c.
>   linux-user: Load symbols from the interpreter.
>   linux-user: Improve consistency checking in elf headers.
>   linux-user: Put the stack guard page at the top.
>   linux-user: Remove partial support for a.out interpreters.
>   linux-user: Extract load_elf_image from load_elf_interp.
>   linux-user: Re-use load_elf_image for the main binary.
> 
>  elf.h                  |   44 ++
>  linux-user/elfload.c   | 1791 ++++++++++++++++++++----------------------------
>  linux-user/linuxload.c |   17 +-
>  linux-user/qemu.h      |    7 +-
>  4 files changed, 794 insertions(+), 1065 deletions(-)
> 
> 

  parent reply	other threads:[~2010-07-29  7:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 17:25 [Qemu-devel] [PATCH 00/12 v4] Clean up linux-user/elfload.c Richard Henderson
2010-07-27 17:25 ` [Qemu-devel] [PATCH 01/12] linux-user: Handle filesz < memsz for any PT_LOAD segment Richard Henderson
2010-07-27 17:25 ` [Qemu-devel] [PATCH 02/12] Add more DT_* and AT_* constants to qemu's copy of elf.h Richard Henderson
2010-07-27 17:25 ` [Qemu-devel] [PATCH 03/12] linux-user: Reindent elfload.c Richard Henderson
2010-07-27 17:25 ` [Qemu-devel] [PATCH 04/12] linux-user: Reduce lseek+reads while loading elf files Richard Henderson
2010-07-27 17:25 ` [Qemu-devel] [PATCH 05/12] linux-user: Define ELF_DATA generically Richard Henderson
2010-07-27 17:25 ` [Qemu-devel] [PATCH 06/12] linux-user: Clean up byte-swapping in elfload.c Richard Henderson
2010-07-27 17:25 ` [Qemu-devel] [PATCH 07/12] linux-user: Load symbols from the interpreter Richard Henderson
2010-07-27 18:45   ` malc
2010-07-27 19:59     ` Richard Henderson
2010-07-27 20:39       ` malc
2010-07-27 20:44         ` malc
2010-07-28 22:16   ` Edgar E. Iglesias
2010-07-27 17:25 ` [Qemu-devel] [PATCH 08/12] linux-user: Improve consistency checking in elf headers Richard Henderson
2010-07-27 17:25 ` [Qemu-devel] [PATCH 09/12] linux-user: Put the stack guard page at the top Richard Henderson
2010-07-27 17:25 ` [Qemu-devel] [PATCH 10/12] linux-user: Remove partial support for a.out interpreters Richard Henderson
2010-07-27 17:25 ` [Qemu-devel] [PATCH 11/12] linux-user: Extract load_elf_image from load_elf_interp Richard Henderson
2010-07-28 22:00   ` Edgar E. Iglesias
2010-07-28 23:18     ` Richard Henderson
2010-07-27 17:25 ` [Qemu-devel] [PATCH 12/12] linux-user: Re-use load_elf_image for the main binary Richard Henderson
2010-07-29  7:09 ` Edgar E. Iglesias [this message]
2010-08-09 16:52 ` [Qemu-devel] [PATCH 00/12 v4] Clean up linux-user/elfload.c Jan-Simon Möller
2010-08-10 16:21   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100729070941.GA16888@laped.lan \
    --to=edgar.iglesias@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.