From: Christoph Hellwig <hch@lst.de>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] return EINVAL when thawing unfrozen filesystems
Date: Thu, 29 Jul 2010 10:07:31 +0200 [thread overview]
Message-ID: <20100729080731.GA29364@lst.de> (raw)
In-Reply-To: <4C5080AA.6060206@redhat.com>
On Wed, Jul 28, 2010 at 02:10:34PM -0500, Eric Sandeen wrote:
> The iterate_supers() loop in do_thaw_all() assumes
> that we can call thaw_bdev() until we hit an error; when
> I wrote this, we got -EINVAL when requesting a thaw of
> an unfrozen bdev. (it called until error because we
> may have nested freezes).
>
> However, commit 4504230a (freeze_bdev: grab active
> reference to frozen superblocks) changed this so that
> we get a return of 0 in this case, and do_thaw_all()
> spins forever when an emergency system-wide thaw
> is requested.
>
> It looks to me like the change was inadvertent,
> so this patch changes it back.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2010-07-29 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 19:10 [PATCH] return EINVAL when thawing unfrozen filesystems Eric Sandeen
2010-07-29 8:07 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100729080731.GA29364@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.