diff for duplicates of <20100729132223.GA19715@albatros> diff --git a/a/1.txt b/N1/1.txt index 72879e9..6f39f46 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -12,7 +12,7 @@ don't try to fix it as I might create new complex locking problem. if (chip->priv) { struct flchip_shared *shared = chip->priv; - spin_lock(&shared->lock); - if (shared->writing = chip && chip->oldstate = FL_READY) { + if (shared->writing == chip && chip->oldstate == FL_READY) { /* We own the ability to write, but we're done */ shared->writing = shared->erasing; if (shared->writing && shared->writing != chip) { @@ -29,7 +29,7 @@ don't try to fix it as I might create new complex locking problem. if (chip->priv) { struct flchip_shared *shared = chip->priv; - spin_lock(&shared->lock); - if (shared->writing = chip && chip->oldstate = FL_READY) { + if (shared->writing == chip && chip->oldstate == FL_READY) { /* We own the ability to write, but we're done */ shared->writing = shared->erasing; if (shared->writing && shared->writing != chip) { diff --git a/a/content_digest b/N1/content_digest index 6200b0e..210a92a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Vasiliy Kulikov <segooon@gmail.com>\0" "Subject\0[bug] Fixing mutex_lock() under held spinlock\0" - "Date\0Thu, 29 Jul 2010 13:22:23 +0000\0" + "Date\0Thu, 29 Jul 2010 17:22:23 +0400\0" "To\0Artem Bityutskiy <Artem.Bityutskiy@nokia.com>" David Woodhouse <David.Woodhouse@intel.com> Nicolas Pitre <nico@fluxnic.net> @@ -26,7 +26,7 @@ " \tif (chip->priv) {\n" " \t\tstruct flchip_shared *shared = chip->priv;\n" "-\t\tspin_lock(&shared->lock);\n" - " \t\tif (shared->writing = chip && chip->oldstate = FL_READY) {\n" + " \t\tif (shared->writing == chip && chip->oldstate == FL_READY) {\n" " \t\t\t/* We own the ability to write, but we're done */\n" " \t\t\tshared->writing = shared->erasing;\n" " \t\t\tif (shared->writing && shared->writing != chip) {\n" @@ -43,7 +43,7 @@ " \tif (chip->priv) {\n" " \t\tstruct flchip_shared *shared = chip->priv;\n" "-\t\tspin_lock(&shared->lock);\n" - " \t\tif (shared->writing = chip && chip->oldstate = FL_READY) {\n" + " \t\tif (shared->writing == chip && chip->oldstate == FL_READY) {\n" " \t\t\t/* We own the ability to write, but we're done */\n" " \t\t\tshared->writing = shared->erasing;\n" " \t\t\tif (shared->writing && shared->writing != chip) {\n" @@ -58,4 +58,4 @@ "thanks,\n" Vasiliy -f2d397f97656f61a1bbb33b72f5249d0d9377d6ae6409569d74a72b07c8b50d7 +700649bbba3cfce0d1ba0c3c0002b1d3b182f0939089a2e9d809a14c7de7f054
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.