From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: alsa-devel@alsa-project.org, Kukjin Kim <kgene.kim@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Ben Dooks <ben@simtec.co.uk>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] ARM: S5PV210: Add the GPIO lib
Date: Thu, 29 Jul 2010 10:40:39 -0700 [thread overview]
Message-ID: <20100729174038.GF24781@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4C4F9E4D.4090608@samsung.com>
On Wed, Jul 28, 2010 at 12:04:45PM +0900, Chanwoo Choi wrote:
> This patch add the definition of GPIO to support WM8994 audio codec on
> I2C bus.
>
> Signed-off-by : Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by : Kyungmin Park <kyungmin.park@samsung.com>
This should come before the patch using it in your patch series, that
way things won't break when people do git bisect and try to build the
first patch without the second. The changelog could also do with a bit
of a cleanup - this isn't something that's specific to a particular
board, it's adding support for the GPIOs for whatever function they are
needed on any board using this processor.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: S5PV210: Add the GPIO lib
Date: Thu, 29 Jul 2010 10:40:39 -0700 [thread overview]
Message-ID: <20100729174038.GF24781@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4C4F9E4D.4090608@samsung.com>
On Wed, Jul 28, 2010 at 12:04:45PM +0900, Chanwoo Choi wrote:
> This patch add the definition of GPIO to support WM8994 audio codec on
> I2C bus.
>
> Signed-off-by : Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by : Kyungmin Park <kyungmin.park@samsung.com>
This should come before the patch using it in your patch series, that
way things won't break when people do git bisect and try to build the
first patch without the second. The changelog could also do with a bit
of a cleanup - this isn't something that's specific to a particular
board, it's adding support for the GPIOs for whatever function they are
needed on any board using this processor.
next prev parent reply other threads:[~2010-07-29 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 3:04 [PATCH 2/2] ARM: S5PV210: Add the GPIO lib Chanwoo Choi
2010-07-28 3:04 ` Chanwoo Choi
2010-07-28 8:09 ` Marek Szyprowski
2010-07-28 8:09 ` Marek Szyprowski
2010-07-28 8:54 ` Chanwoo Choi
2010-07-28 8:54 ` Chanwoo Choi
2010-07-29 17:40 ` Mark Brown [this message]
2010-07-29 17:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100729174038.GF24781@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben@simtec.co.uk \
--cc=cw00.choi@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.