All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Kirill Zut <kirill.zut@promwad.com>
Cc: linux-wireless@vger.kernel.org,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Hin-Tak Leung <htl10@users.sourceforge.net>,
	Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Subject: Re: [PATCH 2.6.34] rtl8187: ad-hoc mode support
Date: Thu, 29 Jul 2010 14:04:27 -0400	[thread overview]
Message-ID: <20100729180426.GC2424@tuxdriver.com> (raw)
In-Reply-To: <201007291835.46159.kirill.zut@promwad.com>

Don't you need something to make it beacon?

On Thu, Jul 29, 2010 at 06:35:45PM +0300, Kirill Zut wrote:
> ---
> This patch makes ad-hoc mode available on RTL8187
> 
> Signed-off-by: Kirill Zut <kirill.zut@promwad.com>
> ---
> --- linux-2.6.x/drivers/net/wireless/rtl818x/rtl8187_dev.c.orig	2010-07-29 14:40:09.000000000 +0300
> +++ linux-2.6.x/drivers/net/wireless/rtl818x/rtl8187_dev.c	2010-07-29 14:59:39.000000000 +0300
> @@ -1032,6 +1032,7 @@ static int rtl8187_add_interface(struct 
>  
>  	switch (vif->type) {
>  	case NL80211_IFTYPE_STATION:
> +	case NL80211_IFTYPE_ADHOC:
>  		break;
>  	default:
>  		goto exit;
> @@ -1178,7 +1179,10 @@ static void rtl8187_bss_info_changed(str
>  			reg = 0;
>  
>  		if (is_valid_ether_addr(info->bssid)) {
> -			reg |= RTL818X_MSR_INFRA;
> +			if (vif->type == NL80211_IFTYPE_ADHOC)
> +				reg |= RTL818X_MSR_ADHOC;
> +			else
> +				reg |= RTL818X_MSR_INFRA;
>  			rtl818x_iowrite8(priv, &priv->map->MSR, reg);
>  		} else {
>  			reg |= RTL818X_MSR_NO_LINK;
> @@ -1502,7 +1506,8 @@ static int __devinit rtl8187_probe(struc
>  	 * XXX: Once this driver supports anything that requires
>  	 *	beacons it must implement IEEE80211_TX_CTL_ASSIGN_SEQ.
>  	 */
> -	dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
> +	dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
> +				      BIT(NL80211_IFTYPE_ADHOC);
>  
>  	if ((id->driver_info == DEVICE_RTL8187) && priv->is_rtl8187b)
>  		printk(KERN_INFO "rtl8187: inconsistency between id with OEM"
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  parent reply	other threads:[~2010-07-29 18:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201007291835.46159.kirill.zut@promwad.com>
2010-07-29 17:01 ` [PATCH 2.6.34] rtl8187: ad-hoc mode support Hin-Tak Leung
2010-07-29 18:04 ` John W. Linville [this message]
2010-07-29 19:01   ` Larry Finger
2010-07-29 19:03   ` Larry Finger
2010-07-29 20:52     ` Hin-Tak Leung
2010-07-30 23:53       ` jpo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100729180426.GC2424@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=herton@mandriva.com.br \
    --cc=htl10@users.sourceforge.net \
    --cc=kirill.zut@promwad.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.