From: Thomas Rast <trast@student.ethz.ch>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Dmitry V. Levin" <ldv@altlinux.org>, <git@vger.kernel.org>
Subject: Re: [PATCH] checkout: add a test for creating a new branch with regexp as a starting point
Date: Fri, 30 Jul 2010 01:36:13 +0200 [thread overview]
Message-ID: <201007300136.13501.trast@student.ethz.ch> (raw)
In-Reply-To: <AANLkTi=Qf1OUmjkpL-6e8gT8MU9G=m37sxrdAoyj5=R0@mail.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> On Thu, Jul 29, 2010 at 22:01, Dmitry V. Levin <ldv@altlinux.org> wrote:
> > +test_expect_success checkout '
> > + git checkout -b new_branch :/first
> > +'
> > +
> > +test_done
>
> ...it looks like this can just be added to the end of
> t2018-checkout-branch.sh instead of creating a new test. Creating a
> new file just for a single test for such a simple feature is a bit of
> an overkill.
It should also use test_expect_failure unless you expect to have a fix
soon, otherwise it would stop the test suite from running through.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-07-29 23:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 22:01 [PATCH] checkout: add a test for creating a new branch with regexp as a starting point Dmitry V. Levin
2010-07-29 23:07 ` Ævar Arnfjörð Bjarmason
2010-07-29 23:36 ` Thomas Rast [this message]
2010-08-02 21:04 ` Junio C Hamano
2010-07-30 8:44 ` Dmitry V. Levin
2010-07-30 11:54 ` Ævar Arnfjörð Bjarmason
2010-07-30 19:13 ` When to use test_commit (Re: [PATCH] checkout: add a test for creating a new branch with regexp as a starting point) Jonathan Nieder
2010-07-30 20:20 ` Ævar Arnfjörð Bjarmason
2010-07-31 0:18 ` [PATCH 1/2] test-lib.sh: introduce 4th argument to test_commit() specifying a tag name Dmitry V. Levin
2010-07-31 0:39 ` Ævar Arnfjörð Bjarmason
2010-07-31 1:56 ` [PATCH 1/2 v2] " Dmitry V. Levin
2010-07-31 10:23 ` Ævar Arnfjörð Bjarmason
2010-07-31 0:19 ` [PATCH 2/2] checkout: add a test for creating a new branch with regexp as a starting point Dmitry V. Levin
2010-07-31 0:44 ` Ævar Arnfjörð Bjarmason
2010-07-31 1:44 ` [PATCH 2/2 v2] " Dmitry V. Levin
2010-07-31 10:24 ` Ævar Arnfjörð Bjarmason
2010-08-05 21:24 ` [PATCH 2/2 v3] " Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007300136.13501.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=ldv@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.