From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] libxl: move blktap-specific code into libxl_blktap.c Date: Fri, 30 Jul 2010 10:40:27 +0200 Message-ID: <201007301040.28331.Christoph.Egger@amd.com> References: <201007201831.21416.Christoph.Egger@amd.com> <201007291846.45108.Christoph.Egger@amd.com> <19537.49697.129250.664039@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19537.49697.129250.664039@mariner.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "xen-devel@lists.xensource.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Thursday 29 July 2010 20:02:09 Ian Jackson wrote: > Christoph Egger writes ("[PATCH] libxl: move blktap-specific code into libxl_blktap.c"): > > libxl: move blktap-specific code into libxl_blktap.c > > Except, once again, this is not _pure_ motion. You need to split the > patch up so that, in the code motion patch, > > diff -u <(hg diff tools/libxl/libxl.c | perl -pe 's/^[-+]/ $& eq "-" ? > "+" : "-" /e' ) <(hg diff tools/libxl/libxl_blktap.c) > > doesn't produce any substantive output. I'm sorry, I don't know perl. And this command fails with syntax error: '(' unexpected. I haven't send the patch yesterday. It was late for me. You seem to respond always in the late afternoon (CEST). In which timezone are you ? Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632