From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, clalance@redhat.com,
Miguel Di Ciurcio Filho <miguel.filho@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name
Date: Fri, 30 Jul 2010 11:52:23 -0300 [thread overview]
Message-ID: <20100730115223.70adec0d@redhat.com> (raw)
In-Reply-To: <m3aap981z6.fsf@blackfin.pond.sub.org>
On Fri, 30 Jul 2010 16:43:09 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> Luiz Capitulino <lcapitulino@redhat.com> writes:
>
> > On Fri, 30 Jul 2010 11:34:57 +0200
> > Markus Armbruster <armbru@redhat.com> wrote:
> >
> >> Miguel Di Ciurcio Filho <miguel.filho@gmail.com> writes:
> >>
> >> > This patch address two issues.
> >> >
> >> > 1) When savevm is run using an previously saved snapshot id or name, it will
> >> > delete the original and create a new one, using the same id and name and not
> >> > prompting the user of what just happened.
> >> >
> >> > This behaviour is not good, IMHO.
> >>
> >> Debatable.
> >
> > Automatically destroying previously saved data without any notice seems
> > a quite bad behavior to me.
>
> See cp, mv ;)
Nah, unrelated because the name of the command imply that. A best comparison
would be lvcreate have such semantics.
next prev parent reply other threads:[~2010-07-30 14:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 19:30 [Qemu-devel] [PATCH 0/3] savem: various cleanups Miguel Di Ciurcio Filho
2010-07-28 19:30 ` [Qemu-devel] [PATCH 1/3] cleanup: bdrv_snaphost_find() returns zero or -ENOENT Miguel Di Ciurcio Filho
2010-07-30 9:44 ` Markus Armbruster
2010-07-30 13:38 ` Luiz Capitulino
2010-07-28 19:30 ` [Qemu-devel] [PATCH 2/3] cleanup: del_existing_snapshots() must return the upstream error code Miguel Di Ciurcio Filho
2010-07-30 9:45 ` Markus Armbruster
2010-07-30 20:28 ` Miguel Di Ciurcio Filho
2010-08-02 11:06 ` Markus Armbruster
2010-07-28 19:30 ` [Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name Miguel Di Ciurcio Filho
2010-07-30 9:34 ` Markus Armbruster
2010-07-30 13:43 ` Luiz Capitulino
2010-07-30 14:43 ` Markus Armbruster
2010-07-30 14:52 ` Luiz Capitulino [this message]
2010-08-02 14:08 ` Chris Lalancette
2010-07-30 13:39 ` [Qemu-devel] " Luiz Capitulino
2010-07-30 14:42 ` Miguel Di Ciurcio Filho
2010-07-30 14:53 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730115223.70adec0d@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=clalance@redhat.com \
--cc=kwolf@redhat.com \
--cc=miguel.filho@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.