From: pieterg@gmx.com (pieterg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PXA: Colibri320: Add M41T00 RTC support
Date: Sat, 31 Jul 2010 09:26:03 +0200 [thread overview]
Message-ID: <201007310926.03292.pieterg@gmx.com> (raw)
In-Reply-To: <1280543453-28237-1-git-send-email-marek.vasut@gmail.com>
On Saturday 31 July 2010 04:30:53 Marek Vasut wrote:
> +#if defined(CONFIG_RTC_DRV_DS1307) ||
> defined(CONFIG_RTC_DRV_DS1307_MODULE)
> +static mfp_cfg_t colibri_pxa320_i2c_pin_config[] __initdata = {
> + GPIO32_I2C_SCL,
> + GPIO33_I2C_SDA,
> +};
Should the i2c pins really depend on the DS1307 config?
On my board, I use a different rtc. So I do need the I2C pins to be
configured, but I don't need the DS1307.
A few weeks ago I submitted
[PATCH 4/5] colibri-pxa3xx: add i2c support
which initializes the i2c gpio's, depending on CONFIG_I2C ||
CONFIG_I2C_MODULE
(but the patch was rejected, argueing that people might want to use
different gpio's for i2c)
Rgds, Pieter
next prev parent reply other threads:[~2010-07-31 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 2:30 [PATCH] PXA: Colibri320: Add M41T00 RTC support Marek Vasut
2010-07-31 7:26 ` pieterg [this message]
2010-07-31 7:33 ` Marek Vasut
2010-07-31 9:05 ` Daniel Mack
2010-07-31 9:22 ` Russell King - ARM Linux
2010-08-04 6:25 ` Eric Miao
2010-07-31 10:34 ` Marek Vasut
2010-07-31 9:16 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007310926.03292.pieterg@gmx.com \
--to=pieterg@gmx.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.