From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] CIFS: Remove __exit mark from cifs_exit_dns_resolver() Date: Sun, 1 Aug 2010 14:40:59 +0200 Message-ID: <20100801124059.GA7977@pengutronix.de> References: <20100730142519.18287.22053.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jeff Layton To: David Howells Return-path: Content-Disposition: inline In-Reply-To: <20100730142519.18287.22053.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Hello, On Fri, Jul 30, 2010 at 03:25:19PM +0100, David Howells wrote: > Remove the __exit mark from cifs_exit_dns_resolver() as it's called b= y the > module init routine in case of error, and so may have been discarded = during > linkage. =46rom time to time I think about introducing something like __init_or_exit that puts a function into .init.text if .exit.text is discarded. Is it worth the effort? Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755434Ab0HAMlN (ORCPT ); Sun, 1 Aug 2010 08:41:13 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:54841 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753678Ab0HAMlM (ORCPT ); Sun, 1 Aug 2010 08:41:12 -0400 Date: Sun, 1 Aug 2010 14:40:59 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: David Howells Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton Subject: Re: [PATCH] CIFS: Remove __exit mark from cifs_exit_dns_resolver() Message-ID: <20100801124059.GA7977@pengutronix.de> References: <20100730142519.18287.22053.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20100730142519.18287.22053.stgit@warthog.procyon.org.uk> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Fri, Jul 30, 2010 at 03:25:19PM +0100, David Howells wrote: > Remove the __exit mark from cifs_exit_dns_resolver() as it's called by the > module init routine in case of error, and so may have been discarded during > linkage. >>From time to time I think about introducing something like __init_or_exit that puts a function into .init.text if .exit.text is discarded. Is it worth the effort? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |