All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Rees <rees@umich.edu>
To: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFS: Fix build failure on !CONFIG_NFS_V3 && !CONFIG_NFS_V3
Date: Sun, 1 Aug 2010 11:33:35 -0400	[thread overview]
Message-ID: <20100801153335.GB5376@merit.edu> (raw)
In-Reply-To: <20100801064415.GA10523@elte.hu>

Ingo Molnar wrote:

  The nfs_commit_inode() prototype:
  
   #if defined(CONFIG_NFS_V3) || defined(CONFIG_NFS_V4)
   extern int  nfs_commit_inode(struct inode *, int);
   extern struct nfs_write_data *nfs_commitdata_alloc(void);
   extern void nfs_commit_free(struct nfs_write_data *wdata);
   #endif
  
  is missing if the kernel is configured for legacy NFS:
  
   CONFIG_NFS_FS=y
   # CONFIG_NFS_V3 is not set
   # CONFIG_NFS_V4 is not set

I didn't even know you could do that.  Is it useful?  Should we just
disallow it?

  reply	other threads:[~2010-08-01 15:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-30 19:43 [GIT PULL] Please pull NFS client bugfixes for 2.6.35-rc6 Trond Myklebust
2010-08-01  6:44 ` [PATCH] NFS: Fix build failure on !CONFIG_NFS_V3 && !CONFIG_NFS_V3 Ingo Molnar
2010-08-01 15:33   ` Jim Rees [this message]
2010-08-01 17:10   ` Linus Torvalds
2010-08-01 17:10     ` Linus Torvalds
2010-08-01 17:35     ` Trond Myklebust
2010-08-01 17:35       ` Trond Myklebust
2010-08-01 17:40       ` [PATCH] NFS: Fix a typo in include/linux/nfs_fs.h Trond Myklebust
2010-08-01 19:32         ` Ingo Molnar
2010-08-01 19:45       ` [PATCH] NFS: Fix build failure on !CONFIG_NFS_V3 && !CONFIG_NFS_V3 Christoph Hellwig
2010-08-01 19:56         ` Myklebust, Trond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100801153335.GB5376@merit.edu \
    --to=rees@umich.edu \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.