From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Only copy skb data for multiple broadcasts
Date: Sun, 1 Aug 2010 17:28:53 +0200 [thread overview]
Message-ID: <201008011728.53733.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1279923269-26513-1-git-send-email-sven.eckelmann@gmx.de>
On Saturday 24 July 2010 00:14:29 Sven Eckelmann wrote:
> batman-adv tries to resend broadcasts on all interfaces up to three
> times. For each round and each interface it must provide a skb which
> gets consumed by the sending function.
>
> It is unnecessary to copy the data of each broadcast because the actual
> data is either not shared or already copied by add_bcast_packet_to_list.
> So it is enough to just copy the skb control data
I think the reason to call skb_copy() is the following dev_queue_xmit() call
which will consume the given skb. If we consider a case of having 3 interfaces
all 3 cloned skbs point to the same data while going out via different
interfaces ? I wonder whether that can work ?!
Cheers,
Marek
next prev parent reply other threads:[~2010-08-01 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 22:14 [B.A.T.M.A.N.] [PATCH] batman-adv: Only copy skb data for multiple broadcasts Sven Eckelmann
2010-08-01 15:28 ` Marek Lindner [this message]
2010-08-01 15:39 ` Sven Eckelmann
2010-08-03 8:40 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008011728.53733.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.