All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Ortiz <sameo@linux.intel.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH RESEND] jz4740-adc: check kmalloc() result
Date: Mon, 2 Aug 2010 10:49:41 +0200	[thread overview]
Message-ID: <20100802084940.GA3334@sortiz-mobl> (raw)
In-Reply-To: <1280711524.6538.3.camel@mola>

Hi Axel,

On Mon, Aug 02, 2010 at 09:12:04AM +0800, Axel Lin wrote:
> >From 40f965e63c4aefb402d85cf8392681565e172d2d Mon Sep 17 00:00:00 2001
> From: Axel Lin <axel.lin@gmail.com>
> Date: Mon, 2 Aug 2010 09:02:02 +0800
> Subject: [PATCH] jz4740-adc: check kmalloc() result
> 
> If kmalloc() fails exit with -ENOMEM.
Thanks a lot, patch applied against my for-next branch.

Cheers,
Samuel.


> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> This patch is against linux-next.
> This resend separates the fix for jz4740-hwmon and jz474-adc in 2 patches.
>  drivers/mfd/jz4740-adc.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c
> index 7a844ae..2846d24 100644
> --- a/drivers/mfd/jz4740-adc.c
> +++ b/drivers/mfd/jz4740-adc.c
> @@ -260,6 +260,10 @@ static int __devinit jz4740_adc_probe(struct platform_device *pdev)
>  	int irq;
>  
>  	adc = kmalloc(sizeof(*adc), GFP_KERNEL);
> +	if (!adc) {
> +		dev_err(&pdev->dev, "Failed to allocate driver structure\n");
> +		return -ENOMEM;
> +	}
>  
>  	adc->irq = platform_get_irq(pdev, 0);
>  	if (adc->irq < 0) {
> -- 
> 1.5.4.3
> 
> 
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

      reply	other threads:[~2010-08-02  8:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-02  1:12 [PATCH RESEND] jz4740-adc: check kmalloc() result Axel Lin
2010-08-02  8:49 ` Samuel Ortiz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100802084940.GA3334@sortiz-mobl \
    --to=sameo@linux.intel.com \
    --cc=axel.lin@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.