From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Jan Friedrich <jft@dev2day.de>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [Patch] ath9k: fix erased ieee80211_rx_status.mactime
Date: Mon, 2 Aug 2010 13:21:37 -0700 [thread overview]
Message-ID: <20100802202137.GC8920@tux> (raw)
In-Reply-To: <4C57278E.1030601@dev2day.de>
On Mon, Aug 02, 2010 at 01:16:14PM -0700, Jan Friedrich wrote:
> This patch addresses the erasure of ieee80211_rx_status.mactime.
>
> After the mactime is set in "ath_rx_tasklet" it is immediately nulled in
> "ath9k_rx_skb_preprocess".
What effect does this have? What issue does this fix? Is this a
fix which also needs to be propagated to the stable kernels, if so
why? etc.
Your patch describes what it does, it doesn't say why its a good
fix or what was affected before. Please clarify all this as best
as you can so we can help ACK/NACK/propagate the patch to stable
if it is appropriate.
Luis
> requeue_skb = ath_rxbuf_alloc(common, common->rx_bufsize, GFP_ATOMIC);
next prev parent reply other threads:[~2010-08-02 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 20:16 [Patch] ath9k: fix erased ieee80211_rx_status.mactime Jan Friedrich
2010-08-02 20:21 ` Luis R. Rodriguez [this message]
2010-08-02 20:35 ` Jan Friedrich
2010-08-02 20:38 ` Luis R. Rodriguez
2010-08-02 20:48 ` Jan Friedrich
2010-08-02 20:52 ` Luis R. Rodriguez
-- strict thread matches above, loose matches on Subject: below --
2010-08-02 21:55 Jan Friedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802202137.GC8920@tux \
--to=lrodriguez@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=jft@dev2day.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.