All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Steve Sakoman <sakoman@gmail.com>
Cc: Mickael Chazaux <mickael.chazaux@gmail.com>,
	linux-omap@vger.kernel.org,
	Roman Tereshonkov <roman.tereshonkov@nokia.com>
Subject: Re: [Regression] ads7846.c touchscreen controller driver reports wrong X,Y values
Date: Tue, 3 Aug 2010 10:27:57 +0300	[thread overview]
Message-ID: <20100803072757.GR12293@atomide.com> (raw)
In-Reply-To: <AANLkTilh7VrS1zZLSmuj-BFYvm34mkF_uwk9B7TpyYYz@mail.gmail.com>

* Steve Sakoman <sakoman@gmail.com> [100710 01:10]:
> On Tue, May 25, 2010 at 8:54 AM, Mickael Chazaux
> <mickael.chazaux@gmail.com> wrote:
> > Hi,
> >
> > I am working on adding the support of an omap3 based board in the
> > kernel. This board uses an ADS7843 touchscreen controller, on the SPI
> > bus. The in-kernel driver (drivers/input/touchscreen/ads7646.c) works
> > fine with the 2.6.33 kernel. When updating to the 2.6.34 kernel the
> > values reported by the driver were garbage. I had to revert this
> > commit [1] to make it work again. Can someone confirm that this driver
> > still works with other OMAP boards?
> >
> > [1] a330ce2001b290c59fe98c37e981683ef0a75fdf
> 
> I can confirm that the above patch also breaks the ADS7846 driver on
> Overo.  Reverting it results in correct operation.

Hmm, does reading the OMAP2_MCSPI_CHCONF0 register have some side effect?

Regards,

Tony

      reply	other threads:[~2010-08-03  7:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-25 15:54 [Regression] ads7846.c touchscreen controller driver reports wrong X,Y values Mickael Chazaux
2010-07-09 22:17 ` Steve Sakoman
2010-08-03  7:27   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100803072757.GR12293@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=mickael.chazaux@gmail.com \
    --cc=roman.tereshonkov@nokia.com \
    --cc=sakoman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.