All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sanjeev Premi <premi@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap2: fix assorted compiler warnings
Date: Tue, 3 Aug 2010 10:51:15 +0300	[thread overview]
Message-ID: <20100803075114.GT12293@atomide.com> (raw)
In-Reply-To: <1279016650-20459-1-git-send-email-premi@ti.com>

* Sanjeev Premi <premi@ti.com> [100713 13:26]:
> This patch fixes these compiler warnings:

> --- a/arch/arm/mach-omap2/mux.c
> +++ b/arch/arm/mach-omap2/mux.c
> @@ -87,7 +87,7 @@ static char *omap_mux_options;
>  int __init omap_mux_init_gpio(int gpio, int val)
>  {
>  	struct omap_mux_entry *e;
> -	struct omap_mux *gpio_mux;
> +	struct omap_mux *gpio_mux=NULL;

Please use spaces around = like *gpio_mux = NULL;

>  	u16 old_mode;
>  	u16 mux_mode;
>  	int found = 0;
> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index 9b7e354..831e6bc 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -2082,7 +2082,7 @@ void omap2_gpio_prepare_for_idle(int power_state)
>  
>  	for (i = min; i < gpio_bank_count; i++) {
>  		struct gpio_bank *bank = &gpio_bank[i];
> -		u32 l1, l2;
> +		u32 l1=0, l2=0;
>  
>  		if (bank->dbck_enable_mask)
>  			clk_disable(bank->dbck);

Here too.

> @@ -2149,7 +2149,7 @@ void omap2_gpio_resume_after_idle(void)
>  		min = 1;
>  	for (i = min; i < gpio_bank_count; i++) {
>  		struct gpio_bank *bank = &gpio_bank[i];
> -		u32 l, gen, gen0, gen1;
> +		u32 l=0, gen, gen0, gen1;
>  
>  		if (bank->dbck_enable_mask)
>  			clk_enable(bank->dbck);

And here.

Regards,

Tony

  reply	other threads:[~2010-08-03  7:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-13 10:24 [PATCH] omap2: fix assorted compiler warnings Sanjeev Premi
2010-08-03  7:51 ` Tony Lindgren [this message]
2010-08-09 11:28 ` Premi, Sanjeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100803075114.GT12293@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=premi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.