From: Tony Lindgren <tony@atomide.com>
To: janboe <janboe.ye@gmail.com>
Cc: khilman@deeprootsystems.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap: gpio: omap3_gpio_pads_init current only works for omap3
Date: Tue, 3 Aug 2010 10:54:52 +0300 [thread overview]
Message-ID: <20100803075451.GU12293@atomide.com> (raw)
In-Reply-To: <20100713145953.GA17852@localhost.localdomain>
* janboe <janboe.ye@gmail.com> [100713 18:06]:
> Since omap4 gpio pad config offset is different with omap3, so
> omap3_gpio_pads_init only works for omap3, and this will break
> omap4 build.
<snip>
> -/*
> - * Following pad init code in addition to the context / restore hooks are
> - * needed to fix glitches in GPIO outputs during off-mode. See OMAP3
> - * errate section 1.158
> - */
> -static int __init omap3_gpio_pads_init(void)
> -{
> - int i, j, min, max, gpio_amt;
> - u16 offset;
How about just add this to the existing function:
if (!cpu_is_omap34xx())
return -ENODEV;
Regards,
Tony
prev parent reply other threads:[~2010-08-03 7:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 14:59 [PATCH] omap: gpio: omap3_gpio_pads_init current only works for omap3 janboe
2010-08-03 7:54 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100803075451.GU12293@atomide.com \
--to=tony@atomide.com \
--cc=janboe.ye@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.