From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 03 Aug 2010 21:51:38 +0000 Subject: Re: [PATCH 8/9] arch/powerpc/kernel: Drop unnecessary null test Message-Id: <20100803215137.GU26313@bicker> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: devicetree-discuss@lists.ozlabs.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Paul Mackerras On Tue, Aug 03, 2010 at 11:35:17PM +0200, Julia Lawall wrote: > diff --git a/arch/powerpc/kernel/pci_of_scan.c b/arch/powerpc/kernel/pci_of_scan.c > index 6ddb795..62dd363 100644 > --- a/arch/powerpc/kernel/pci_of_scan.c > +++ b/arch/powerpc/kernel/pci_of_scan.c > @@ -336,8 +336,7 @@ static void __devinit __of_scan_bus(struct device_node *node, > if (dev->hdr_type = PCI_HEADER_TYPE_BRIDGE || > dev->hdr_type = PCI_HEADER_TYPE_CARDBUS) { > struct device_node *child = pci_device_to_OF_node(dev); > - if (dev) > - of_scan_pci_bridge(child, dev); > + of_scan_pci_bridge(child, dev); The intention was probably to check "child" instead of "dev". pci_device_to_OF_node() can return NULL. On the other hand the code has been this way for a year and no one has complained... regards, dan carpenter > } > } > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wy0-f170.google.com (mail-wy0-f170.google.com [74.125.82.170]) by ozlabs.org (Postfix) with ESMTP id 588EDB6EFF for ; Wed, 4 Aug 2010 07:52:05 +1000 (EST) Received: by wye20 with SMTP id 20so5803511wye.15 for ; Tue, 03 Aug 2010 14:52:02 -0700 (PDT) Date: Tue, 3 Aug 2010 23:51:38 +0200 From: Dan Carpenter To: Julia Lawall Subject: Re: [PATCH 8/9] arch/powerpc/kernel: Drop unnecessary null test Message-ID: <20100803215137.GU26313@bicker> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: devicetree-discuss@lists.ozlabs.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Aug 03, 2010 at 11:35:17PM +0200, Julia Lawall wrote: > diff --git a/arch/powerpc/kernel/pci_of_scan.c b/arch/powerpc/kernel/pci_of_scan.c > index 6ddb795..62dd363 100644 > --- a/arch/powerpc/kernel/pci_of_scan.c > +++ b/arch/powerpc/kernel/pci_of_scan.c > @@ -336,8 +336,7 @@ static void __devinit __of_scan_bus(struct device_node *node, > if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE || > dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) { > struct device_node *child = pci_device_to_OF_node(dev); > - if (dev) > - of_scan_pci_bridge(child, dev); > + of_scan_pci_bridge(child, dev); The intention was probably to check "child" instead of "dev". pci_device_to_OF_node() can return NULL. On the other hand the code has been this way for a year and no one has complained... regards, dan carpenter > } > } > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757818Ab0HCVwI (ORCPT ); Tue, 3 Aug 2010 17:52:08 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:64669 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757794Ab0HCVwE (ORCPT ); Tue, 3 Aug 2010 17:52:04 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=MscvfN+6qOYMrm+VvcOx8WHcYnZI6x8JY3LTSrn++WvA8GCxMaxBzsS9FmUSVbDJai 5U96mwfE80TKBFHYF279duttcK9Su+7265yvB3jaHgfABNIW6EEIw6+YnqwJftDvFTDI UEOMAvfqnssFoxjiK1YZ947G+63nU06Lxmy6I= Date: Tue, 3 Aug 2010 23:51:38 +0200 From: Dan Carpenter To: Julia Lawall Cc: Benjamin Herrenschmidt , Paul Mackerras , Grant Likely , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 8/9] arch/powerpc/kernel: Drop unnecessary null test Message-ID: <20100803215137.GU26313@bicker> Mail-Followup-To: Dan Carpenter , Julia Lawall , Benjamin Herrenschmidt , Paul Mackerras , Grant Likely , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, kernel-janitors@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 03, 2010 at 11:35:17PM +0200, Julia Lawall wrote: > diff --git a/arch/powerpc/kernel/pci_of_scan.c b/arch/powerpc/kernel/pci_of_scan.c > index 6ddb795..62dd363 100644 > --- a/arch/powerpc/kernel/pci_of_scan.c > +++ b/arch/powerpc/kernel/pci_of_scan.c > @@ -336,8 +336,7 @@ static void __devinit __of_scan_bus(struct device_node *node, > if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE || > dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) { > struct device_node *child = pci_device_to_OF_node(dev); > - if (dev) > - of_scan_pci_bridge(child, dev); > + of_scan_pci_bridge(child, dev); The intention was probably to check "child" instead of "dev". pci_device_to_OF_node() can return NULL. On the other hand the code has been this way for a year and no one has complained... regards, dan carpenter > } > } > }