All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] S5P: support mmc driver
Date: Wed, 04 Aug 2010 00:33:49 +0200	[thread overview]
Message-ID: <20100803223349.B10E428F@gemini.denx.de> (raw)
In-Reply-To: <4C331C61.9070400@samsung.com>

Dear Minkyu Kang,

In message <4C331C61.9070400@samsung.com> you wrote:
> This patch adds support mmc driver for s5p SoC
...

> +#ifdef DEBUG_S5P_HSMMC
> +#define dbg(x...)       printf(x)
> +#else
> +#define dbg(x...)       do { } while (0)
> +#endif

Can you please rework this code to use the standard debug() macro
instead of your own?

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"...all the  good  computer  designs  are  bootlegged;  the  formally
planned  products,  if  they  are built at all, are dogs!" - David E.
Lundstrom, "A Few Good Men From Univac", MIT Press, 1987

  parent reply	other threads:[~2010-08-03 22:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-06 12:06 [U-Boot] [PATCH 1/2] S5P: support mmc driver Minkyu Kang
2010-07-21  1:14 ` Minkyu Kang
2010-08-03  1:21   ` Minkyu Kang
2010-08-03 22:33 ` Wolfgang Denk [this message]
2010-08-03 23:27   ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100803223349.B10E428F@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.