From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 04 Aug 2010 00:48:16 +0200 Subject: [U-Boot] [PATCH 5/5] New implementation for internal handling of environment variables. In-Reply-To: <201007291116.15503.matthias.fuchs@esd-electronics.com> References: <1279395948-25864-1-git-send-email-wd@denx.de> <201007261652.39368.matthias.fuchs@esd-electronics.com> <20100728211731.04B56152397@gemini.denx.de> <201007291116.15503.matthias.fuchs@esd-electronics.com> Message-ID: <20100803224816.8FF9C28F@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Matthias Fuchs, In message <201007291116.15503.matthias.fuchs@esd-electronics.com> you wrote: > > > Actually neither MAC addresses nor serial# are part of the default > > environment. > Right. But, I'd like to have that described feature in any case. Let's call it different, > but the functionality would be helpful. What about a further option like '-p' for keep > _p_rotected. I see this a s part of a sub-sequent patch (series), which adds flags to variables (like read-only, don't-save, etc.). > > No. We need the address of the pointer variable, so the function can > > store the result pointer there. > Nak. You added &-operator when calling: hexport('\0', &res, ENV_SIZE); > That's one to much. You can also remove the &-operator from this: > res = (char *)&envp->data; > > So the code will look like this: Thanks, will re-check this when I have a little more time. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The more complex the mind, the greater the need for the simplicity of play. -- Kirk, "Shore Leave", stardate 3025.8