All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] 500+ recipes: remove do_stage
Date: Tue, 03 Aug 2010 20:10:40 -0400	[thread overview]
Message-ID: <20100804001040.GE17391@denix.org> (raw)
In-Reply-To: <20100803235811.GC17391@denix.org>

On Tue, Aug 03, 2010 at 07:58:11PM -0400, Denys Dmytriyenko wrote:
> On Tue, Aug 03, 2010 at 11:17:26AM +0200, Koen Kooi wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > On 02-08-10 22:19, Frans Meulenbroeks wrote:
> > > This patch removes all occurrences of
> > > do_stage() {
> > >         autotools_stage_all
> > > }
> > > including all kind of variants w.r.t whitespace
> > 
> > [..]
> > 
> > > my proposal would be to apply it, and if there are a 
> > > few recipes broken after that, accept is as collateral damage and fix 
> > > it afterwards.
> > 
> > Agreed
> > 
> > Acked-by: Koen Kooi <koen@openembedded.org>
> 
> First collateral damage - libxcb was broken, due to xcb-proto.inc having 
> do_stage(). Worked with Khem to find the cause and thanks for pushing the fix:
> 
> http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=b0061845a60d7781f9287ae6955585485f5ba8e9

BTW, just wanted to mention - if corresponding PRs had been bumped, it would 
have been spotted sooner and not only by people with clean TMPDIR... :)

-- 
Denys



  reply	other threads:[~2010-08-04  0:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-02 20:19 [PATCH] 500+ recipes: remove do_stage Frans Meulenbroeks
2010-08-03  9:17 ` Koen Kooi
2010-08-03 23:58   ` Denys Dmytriyenko
2010-08-04  0:10     ` Denys Dmytriyenko [this message]
2010-08-04  2:02       ` Khem Raj
2010-08-04  2:13         ` Khem Raj
2010-08-04  5:54           ` Frans Meulenbroeks
2010-08-04  6:05             ` Frans Meulenbroeks
2010-08-04  5:47       ` Frans Meulenbroeks
2010-08-04 16:50         ` Bernhard Reutner-Fischer
2010-08-04 17:16           ` Frans Meulenbroeks
2010-08-04 17:40             ` Bernhard Reutner-Fischer
2010-08-04 17:52               ` Frans Meulenbroeks
2010-08-04 17:22           ` Koen Kooi
2010-08-04 20:12             ` Bernhard Reutner-Fischer
2010-08-03  9:47 ` Dr. Michael Lauer
2010-08-03 12:44 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100804001040.GE17391@denix.org \
    --to=denis@denix.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.