All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] recipes: Dont inherit autotools_stage.
Date: Tue, 3 Aug 2010 22:24:02 -0700	[thread overview]
Message-ID: <20100804052402.GC7085@gmail.com> (raw)
In-Reply-To: <AANLkTi=WHWm67_GkH7rFSvz+F=_cjP_CgBe5m5ME4tuH@mail.gmail.com>

On (04/08/10 14:37), Graham Gower wrote:
> On 4 August 2010 12:51, Denys Dmytriyenko <denis@denix.org> wrote:
> > 1. Do you expect extensive fallout after this change? Since PRs are again not
> > bumped, people should probably try 2 builds - with existing TMPDIR and with a
> > clean one.
> >
> > 2. This doesn't seem right (special case not handled by your regexp):
> >
> > @@ -60,7 +60,7 @@ do_configure_append() {
> >  }
> >
> >  do_stage() {
> > -       autotools_stage_all
> > +       _all
> >        sed -i s,-l:libusb-gnur.a,,g ${STAGING_LIBDIR}/libusrp.la
> >  }
> >
> > --
> > Denys
> >
> 
> This doesn't look right either.


This is fixed in v2.

> 
> --- a/recipes/bluez/bluez4-libs.inc
> +++ b/recipes/bluez/bluez4-libs.inc
> @@ -10,7 +10,7 @@ SRC_URI =
> "http://www.kernel.org/pub/linux/bluetooth/bluez-${PV}.tar.gz \
> 
>  S = "${WORKDIR}/bluez-${PV}"
> 
> -inherit autotools_stage
> +inherit
>  AUTOTOOLS_STAGE_PKGCONFIG = "1"
> 
>  EXTRA_OECONF = "\
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel



  reply	other threads:[~2010-08-04  5:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-04  2:49 [PATCH] recipes: Dont inherit autotools_stage Khem Raj
2010-08-04  3:21 ` Denys Dmytriyenko
2010-08-04  5:07   ` Graham Gower
2010-08-04  5:24     ` Khem Raj [this message]
2010-08-04  5:26   ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100804052402.GC7085@gmail.com \
    --to=raj.khem@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.