Re: [PATCH 5/6] staging: hv: Increased storvsc ringbuffer and max_io_requests

[Greg KH <gregkh@suse.de>]

On Wed, Aug 04, 2010 at 03:23:09AM +0000, Hank Janssen wrote:
> 
> >>And than Greg KH spoke these words:
> >>On Tue, Aug 03, 2010 at 05:31:55PM +0000, Hank Janssen wrote:
> > >From: Hank Janssen <hjanssen@microsoft.com>
> > >
> > >Increased storvsc ringbuffer and max_io_requests. This now more 
> > >closely mimics the numbers on Hyper-V.
> >
> >What do you mean by this?  The max provided by the hypervisor?
> 
> Max_IO is set to double from what it was before, Hyper-V allows it and
> We have had appliance builder requests to see if it was a problem to increase
> The number.
> 
> Ringbuffer size for storvsc is now increased because I have seen 
> A few buffer problems on extremely busy systems. They where 
> Set pretty low before. And since max_io_requests is increased I
> Really needed to increase the buffer as well.
> 
> >> And will allow more IO requests to take place for the SCSI driver.
> >
> >Which means what, better throughput?  Or just more outstanding requests and the same speed overall?
> 
> It means better throughput of high load systems, else you get buffer
> Contention. 

All good, care to included this in the changelog comment when you resend
this whole series?

thanks,

greg k-h