From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] kprobes: verify jprobe entry point
Date: Thu, 05 Aug 2010 09:59:51 +0000 [thread overview]
Message-ID: <20100805095951.GG9031@bicker> (raw)
In-Reply-To: <1280820323-18929-2-git-send-email-namhyung@gmail.com>
On Thu, Aug 05, 2010 at 11:41:41AM +0200, walter harms wrote:
>
> I am a bit converned about this code here:
> if (kallsyms_lookup_size_offset(addr, NULL, &offset) && offset = 0)
>
> offset is set inside kallsyms_lookup_size_offset(), right ?
> but can you guarantee that the calling sequence is the same on all processors ?
> (it is not in case of functions).
>
Namhyung Kim's version is fine.
regards,
dan carpenter
next prev parent reply other threads:[~2010-08-05 9:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 7:25 [PATCH 2/2] kprobes: verify jprobe entry point Namhyung Kim
2010-08-03 11:27 ` Masami Hiramatsu
2010-08-03 13:00 ` Namhyung Kim
2010-08-03 13:42 ` Namhyung Kim
2010-08-04 4:26 ` Masami Hiramatsu
2010-08-04 13:34 ` Namhyung Kim
2010-08-05 9:06 ` Masami Hiramatsu
2010-08-05 9:41 ` walter harms
2010-08-05 9:47 ` Julia Lawall
2010-08-05 9:59 ` Dan Carpenter [this message]
2010-08-05 11:14 ` Håkon Løvdal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100805095951.GG9031@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.