All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	virtualization@lists.linux-foundation.org,
	Zang Roy <r61911@freescale.com>,
	netdev@vger.kernel.org
Subject: Re: Using virtio as a physical (wire-level) transport
Date: Thu, 5 Aug 2010 16:01:03 -0700	[thread overview]
Message-ID: <20100805230102.GD4757@ovro.caltech.edu> (raw)
In-Reply-To: <20100805213050.GA24984@redhat.com>

On Fri, Aug 06, 2010 at 12:30:50AM +0300, Michael S. Tsirkin wrote:
> Hi Ira,
> 
> > Making my life harder since the last time I tried this, mainline commit
> > 7c5e9ed0c (virtio_ring: remove a level of indirection) has removed the
> > possibility of using an alternative virtqueue implementation. The commit
> > message suggests that you might be willing to add this capability back.
> > Would this be an option?
> 
> Sorry about that.
> 
> With respect to this commit, we only had one implementation upstream
> and extra levels of indirection made extending the API
> much harder for no apparent benefit.
> 
> When there's more than one ring implementation with very small amount of
> common code, I think that it might make sense to readd the indirection
> back, to separate the code cleanly.
> 
> OTOH if the two implementations share a lot of code, I think that it
> might be better to just add a couple of if statements here and there.
> This way compiler even might have a chance to compile the code out if
> the feature is disabled in kernel config.
> 

The virtqueue implementation I envision will be almost identical to the
current virtio_ring virtqueue implementation, with the following
exceptions:

* the "shared memory" will actually be remote, on the PCI BAR of a device
* iowrite32(), ioread32() and friends will be needed to access the memory
* there will only be a fixed number of virtqueues available, due to PCI
  BAR size
* cross-endian virtqueues must work
* kick needs to be cross-machine (using PCI IRQ's)

I don't think it is feasible to add this to the existing implementation.
I think the requirement of being cross-endian will be the hardest to
overcome. Rusty did not envision the cross-endian use case when he
designed this, and it shows, in virtio_ring, virtio_net and vhost. I
have no idea what to do about this. Do you have any ideas?


I plan to create a custom socket similar to tun/macvtap which will use
DMA to transfer around data. This, along with a few other tricks, will
allow me to use vhost_net to operate the device. Along with a custom
virtqueue implementation meeting the requirements above, this seems like
a good plan.

Thanks for responding,
Ira

  reply	other threads:[~2010-08-05 23:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-04 23:04 Using virtio as a physical (wire-level) transport Ira W. Snyder
2010-08-05 21:30 ` Michael S. Tsirkin
2010-08-05 23:01   ` Ira W. Snyder [this message]
2010-08-05 23:20     ` Michael S. Tsirkin
2010-08-06 15:34       ` Ira W. Snyder
2010-08-14 11:34         ` Alexander Graf
2010-08-16  0:19           ` Rusty Russell
2010-08-16  0:19           ` Rusty Russell
2010-09-06 11:19           ` Michael S. Tsirkin
2010-09-06 11:19           ` Michael S. Tsirkin
2010-08-14 11:34         ` Alexander Graf
2010-08-06 15:34       ` Ira W. Snyder
2010-08-05 23:20     ` Michael S. Tsirkin
2010-08-05 23:01   ` Ira W. Snyder
2010-08-05 21:30 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100805230102.GD4757@ovro.caltech.edu \
    --to=iws@ovro.caltech.edu \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=r61911@freescale.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.