From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/9] net classifier: dont allow filters on semi-classful qdisc Date: Fri, 6 Aug 2010 14:58:18 -0700 Message-ID: <20100806145818.66d389eb@nehalam> References: <20100806193548.007978639@vyatta.com> <20100806193558.580890552@vyatta.com> <4C5C7D9F.4040303@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org To: Jarek Poplawski Return-path: Received: from mail.vyatta.com ([76.74.103.46]:33686 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759375Ab0HFV6U (ORCPT ); Fri, 6 Aug 2010 17:58:20 -0400 In-Reply-To: <4C5C7D9F.4040303@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 06 Aug 2010 23:24:47 +0200 Jarek Poplawski wrote: > Stephen Hemminger wrote, On -10.01.-28163 20:59: > > > There are several qdisc which only support a single class (sfq, mq, tbf) > > and the kernel would dereference a null pointer (bind_tcf), if a user > > attempted to apply a filter one of these classes. > > > mq and tbf can't have this issue because they don't have > .tcf_chain class method. sfq should support it on purpose > after this patch: > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7d2681a6ff4f9ab5e48d02550b4c6338f1638998 > and needs tiny fix only. Probably best to fix both ways. Fix sfq to allow filters to be chained, and fix API to prevent refuse to allow qdisc to register with tcf_chain && !bind_tcf